Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Implement the corresponding part in Generator for optional qr code. #31323

Closed
yunhanw-google opened this issue Jan 9, 2024 · 0 comments · Fixed by #33381
Closed

[Android] Implement the corresponding part in Generator for optional qr code. #31323

yunhanw-google opened this issue Jan 9, 2024 · 0 comments · Fixed by #33381
Labels
android

Comments

@yunhanw-google
Copy link
Contributor 

          > This PR only implement the Optional field in Parser, do we have plan to implement the corresponding part in Generator in a separate PR?

That would be my preference since we can generate the qr code using other tools. The optional field parser is more critical for unblocking our companies qr code decision.

Originally posted by @stevePalmerin in #31251 (comment)
@yunhanw-google yunhanw-google mentioned this issue Jan 9, 2024
Merged
@yunhanw-google yunhanw-google changed the title [Android] Implement the corresponding part in Generator for optional qr code? [Android] Implement the corresponding part in Generator for optional qr code. Jan 16, 2024
@yunhanw-google yunhanw-google mentioned this issue May 10, 2024
Merged
@mergify mergify bot closed this as completed in #33381 May 10, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Android May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
android
Projects
[Platform] Android
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Android] Implement qr code generator joonhaengHeo/connectedhomeip
2 participants
@yunhanw-google @bzbarsky-apple