Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SVE] Hanlde receive another RequestCommissioningApproval with the same RequestId #35164

Closed
yufengwangca opened this issue Aug 22, 2024 · 0 comments · Fixed by #35186
Closed

[SVE] Hanlde receive another RequestCommissioningApproval with the same RequestId #35164

yufengwangca opened this issue Aug 22, 2024 · 0 comments · Fixed by #35186
Labels
bug Something isn't working fabric-sync needs triage request sve sve

Comments

@yufengwangca
Copy link
Contributor

yufengwangca commented Aug 22, 2024 •
edited
Loading

Reproduction steps

While the server is in the progressing of reverse commissioning process, and receive another RequestCommissioningApproval with the same RequestId, the server should return proper error code.

We plan to use state machine to guard ongoing reverse commissioning process

Bug prevalence

Always

GitHub hash of the SDK that was being used

c4cdbf6

Platform

raspi

Platform Version(s)

No response

Type

Test Improvement

Testing

Manually tested with SDK

(Optional) If manually tested please explain why this is only manually tested

No response

Anything else?

https://github.com/CHIP-Specifications/connectedhomeip-spec/pull/10312
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fabric-sync needs triage request sve sve
Projects
[Feature] Fabric Synchronization
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fabric-Bridge] Add state machine to CommissionerControlDelegate to guard various unexpected commands
1 participant
@yufengwangca