Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic operations are not supported in YAML, but appear in several tests. #217

Closed
39 tasks
cecille opened this issue Apr 4, 2024 · 2 comments
Closed
39 tasks

Comments

@cecille
Copy link
Contributor

cecille commented Apr 4, 2024

Summary Title:

We have these in several tests. How are these not failing?

Description:

  • src/app/tests/suites/certification/Test_TC_CADMIN_1_3.yaml: value: PIXIT.CADMIN.CwDuration * 1000
  • src/app/tests/suites/certification/Test_TC_CADMIN_1_4.yaml: value: PIXIT.CADMIN.CwDuration * 1000
  • src/app/tests/suites/certification/Test_TC_CC_6_3.yaml: minValue: ColorTempPhysicalMaxMiredsValue - 1
  • src/app/tests/suites/certification/Test_TC_FLW_2_1.yaml: minValue: MinMeasuredVariable + 1
  • src/app/tests/suites/certification/Test_TC_REFALM_2_2.yaml: value: PIXIT.REFALM.AlarmThreshold * 1000
  • src/app/tests/suites/certification/Test_TC_REFALM_2_2.yaml: value: PIXIT.REFALM.AlarmThreshold * 1000
  • src/app/tests/suites/certification/Test_TC_REFALM_2_3.yaml: value: PIXIT.REFALM.AlarmThreshold * 1000
  • src/app/tests/suites/certification/Test_TC_RH_2_1.yaml: minValue: CurrentMinMeasured + 1
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: maxScenes - 1
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: maxScenes - 1
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: maxScenesMinusOne / 2
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: maxScenesMinusOne / 2
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: fabricCapacity - 1
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: fabricCapacity - 2
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: fabricCapacity - 2
  • src/app/tests/suites/certification/Test_TC_S_2_2.yaml: value: fabricCapacity - 3
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: maxScenes - 1
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: maxScenes - 1
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: maxScenesMinusOne / 2
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: maxScenesMinusOne / 2
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: fabricCapacity - 1
  • src/app/tests/suites/certification/Test_TC_S_2_3.yaml: value: fabricCapacity - 2
  • src/app/tests/suites/certification/Test_TC_SWTCH_2_1.yaml: maxValue: NumberOfPositionsValue - 1
  • src/app/tests/suites/certification/Test_TC_TCTL_2_1.yaml: maxValue: MaxTemperatureValue - MinTemperatureValue
  • src/app/tests/suites/certification/Test_TC_TMP_2_1.yaml: minValue: CurrentMinMeasured+1
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml: maxValue: AbsMinCoolSetpointLimitStep5 - MinSetpointDeadBandValue
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml: maxValue: OccupiedCoolingSetpointValue - MinSetpointDeadBandValue
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml: maxValue: MinCoolSetpointLimitValue - MinSetpointDeadBandValue
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_1.yaml: maxValue: MaxCoolSetpointLimitValue - MinSetpointDeadBandValue
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxCoolSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxHeatSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxCoolSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxHeatSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxHeatSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: AbsMaxHeatSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: MaxCoolSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_TSTAT_2_2.yaml: value: AbsMaxCoolSetpointLimitValue + 1000
  • src/app/tests/suites/certification/Test_TC_WNCV_4_3.yaml: value: attrCurrentPositionLiftPercent100ths / 100
  • src/app/tests/suites/certification/Test_TC_WNCV_4_4.yaml: value: attrCurrentPositionTiltPercent100ths / 100

Steps to reproduce:

grep -E '(minValue|maxValue|value):\s*[a-zA-Z0-9.]+\s*[-+/]+\s[a-zA-Z0-9.]' src/app/tests/suites/certification/*.yaml

@cecille
Copy link
Contributor Author

cecille commented Apr 5, 2024

Answer - they're not failing because arithmetic operations ARE supported, but only if you put a space between the operation and the variable. And we just didn't write that down anywhere, so they mysteriously fail if you don't do it right, and it therefore looks like it's totally unsupported.

@cecille
Copy link
Contributor Author

cecille commented Apr 5, 2024

Closing this, will open issue to track the problem with spaces.

@cecille cecille closed this as completed Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant