[Fix] Config : don't clobber existing failure-persistence config during contextualization

matthew-russo · matthew-russo · commit 7a883df82698 · 2024-02-17T16:33:21.000-08:00
diff --git a/proptest/src/test_runner/config.rs b/proptest/src/test_runner/config.rs
@@ -22,8 +22,6 @@ use std::str::FromStr;
 use crate::test_runner::result_cache::{noop_result_cache, ResultCache};
 use crate::test_runner::rng::RngAlgorithm;
 use crate::test_runner::FailurePersistence;
-#[cfg(feature = "std")]
-use crate::test_runner::FileFailurePersistence;
 
 #[cfg(feature = "std")]
 const CASES: &str = "PROPTEST_CASES";
@@ -80,8 +78,6 @@ pub fn contextualize_config(mut result: Config) -> Config {
         }
     }
 
-    result.failure_persistence =
-        Some(Box::new(FileFailurePersistence::default()));
     for (var, value) in
         env::vars_os().filter_map(|(k, v)| k.into_string().ok().map(|k| (k, v)))
     {

Original file line number	Diff line number	Diff line change
`@@ -22,8 +22,6 @@ use std::str::FromStr;`
`22`	`22`	`use crate::test_runner::result_cache::{noop_result_cache, ResultCache};`
`23`	`23`	`use crate::test_runner::rng::RngAlgorithm;`
`24`	`24`	`use crate::test_runner::FailurePersistence;`
`25`		`-#[cfg(feature = "std")]`
`26`		`-use crate::test_runner::FileFailurePersistence;`
`27`	`25`
`28`	`26`	`#[cfg(feature = "std")]`
`29`	`27`	`const CASES: &str = "PROPTEST_CASES";`
`@@ -80,8 +78,6 @@ pub fn contextualize_config(mut result: Config) -> Config {`
`80`	`78`	`}`
`81`	`79`	`}`
`82`	`80`
`83`		`- result.failure_persistence =`
`84`		`- Some(Box::new(FileFailurePersistence::default()));`
`85`	`81`	`for (var, value) in`
`86`	`82`	`env::vars_os().filter_map(\|(k, v)\| k.into_string().ok().map(\|k\| (k, v)))`
`87`	`83`	`{`