buildifier on generated stuff

Author: prestonvanloon

tools/cross-toolchain/configs/clang/bazel_2.1.1/cc/BUILD

@@ -38,7 +38,10 @@ filegroup(
 
 filegroup(
     name = "compiler_deps",
-    srcs = glob(["extra_tools/**"], allow_empty = True) + [":builtin_include_directory_paths"],
+    srcs = glob(
+        ["extra_tools/**"],
+        allow_empty = True,
+    ) + [":builtin_include_directory_paths"],
 )
 
 # This is the entry point for --crosstool_top.  Toolchains are found
@@ -56,8 +59,6 @@ cc_toolchain_suite(
 
 cc_toolchain(
     name = "cc-compiler-k8",
-    toolchain_identifier = "local",
-    toolchain_config = ":local",
     all_files = ":compiler_deps",
     ar_files = ":compiler_deps",
     as_files = ":compiler_deps",
@@ -67,26 +68,65 @@ cc_toolchain(
     objcopy_files = ":empty",
     strip_files = ":empty",
     supports_param_files = 1,
+    toolchain_config = ":local",
+    toolchain_identifier = "local",
 )
 
 cc_toolchain_config(
     name = "local",
-    cpu = "k8",
+    abi_libc_version = "local",
+    abi_version = "local",
+    compile_flags = [
+        "-U_FORTIFY_SOURCE",
+        "-fstack-protector",
+        "-Wall",
+        "-Wthread-safety",
+        "-Wself-assign",
+        "-fcolor-diagnostics",
+        "-fno-omit-frame-pointer",
+    ],
     compiler = "clang",
-    toolchain_identifier = "local",
+    coverage_compile_flags = [
+        "-fprofile-instr-generate",
+        "-fcoverage-mapping",
+    ],
+    coverage_link_flags = ["-fprofile-instr-generate"],
+    cpu = "k8",
+    cxx_builtin_include_directories = [
+        "/usr/local/include",
+        "/usr/lib/clang/10.0.0/include",
+        "/usr/include/x86_64-linux-gnu",
+        "/usr/include",
+        "/usr/include/c++/8",
+        "/usr/include/x86_64-linux-gnu/c++/8",
+        "/usr/include/c++/8/backward",
+    ],
+    cxx_flags = ["-std=c++0x"],
+    dbg_compile_flags = ["-g"],
     host_system_name = "local",
-    target_system_name = "local",
+    link_flags = [
+        "-fuse-ld=/usr/bin/ld.gold",
+        "-Wl,-no-as-needed",
+        "-Wl,-z,relro,-z,now",
+        "-B/usr/bin",
+        "-lm",
+        "-static-libgcc",
+    ],
+    link_libs = ["-l:libstdc++.a"],
+    opt_compile_flags = [
+        "-g0",
+        "-O2",
+        "-D_FORTIFY_SOURCE=1",
+        "-DNDEBUG",
+        "-ffunction-sections",
+        "-fdata-sections",
+    ],
+    opt_link_flags = ["-Wl,--gc-sections"],
+    supports_start_end_lib = True,
     target_libc = "local",
-    abi_version = "local",
-    abi_libc_version = "local",
-    cxx_builtin_include_directories = ["/usr/local/include",
-    "/usr/lib/clang/10.0.0/include",
-    "/usr/include/x86_64-linux-gnu",
-    "/usr/include",
-    "/usr/include/c++/8",
-    "/usr/include/x86_64-linux-gnu/c++/8",
-    "/usr/include/c++/8/backward"],
-    tool_paths = {"ar": "/usr/bin/ar",
+    target_system_name = "local",
+    tool_paths = {
+        "ar": "/usr/bin/ar",
         "ld": "/usr/bin/ld",
         "cpp": "/usr/bin/cpp",
         "gcc": "/usr/bin/clang",
@@ -95,45 +135,21 @@ cc_toolchain_config(
         "nm": "/usr/bin/nm",
         "objcopy": "/usr/bin/objcopy",
         "objdump": "/usr/bin/objdump",
-        "strip": "/usr/bin/strip"},
-    compile_flags = ["-U_FORTIFY_SOURCE",
-    "-fstack-protector",
-    "-Wall",
-    "-Wthread-safety",
-    "-Wself-assign",
-    "-fcolor-diagnostics",
-    "-fno-omit-frame-pointer"],
-    opt_compile_flags = ["-g0",
-    "-O2",
-    "-D_FORTIFY_SOURCE=1",
-    "-DNDEBUG",
-    "-ffunction-sections",
-    "-fdata-sections"],
-    dbg_compile_flags = ["-g"],
-    cxx_flags = ["-std=c++0x"],
-    link_flags = ["-fuse-ld=/usr/bin/ld.gold",
-    "-Wl,-no-as-needed",
-    "-Wl,-z,relro,-z,now",
-    "-B/usr/bin",
-    "-lm",
-    "-static-libgcc"],
-    link_libs = ["-l:libstdc++.a"],
-    opt_link_flags = ["-Wl,--gc-sections"],
-    unfiltered_compile_flags = ["-no-canonical-prefixes",
-    "-Wno-builtin-macro-redefined",
-    "-D__DATE__=\"redacted\"",
-    "-D__TIMESTAMP__=\"redacted\"",
-    "-D__TIME__=\"redacted\""],
-    coverage_compile_flags = ["-fprofile-instr-generate",  "-fcoverage-mapping"],
-    coverage_link_flags = ["-fprofile-instr-generate"],
-    supports_start_end_lib = True,
+        "strip": "/usr/bin/strip",
+    },
+    toolchain_identifier = "local",
+    unfiltered_compile_flags = [
+        "-no-canonical-prefixes",
+        "-Wno-builtin-macro-redefined",
+        "-D__DATE__=\"redacted\"",
+        "-D__TIMESTAMP__=\"redacted\"",
+        "-D__TIME__=\"redacted\"",
+    ],
 )
 
 # Android tooling requires a default toolchain for the armeabi-v7a cpu.
 cc_toolchain(
     name = "cc-compiler-armeabi-v7a",
-    toolchain_identifier = "stub_armeabi-v7a",
-    toolchain_config = ":stub_armeabi-v7a",
     all_files = ":empty",
     ar_files = ":empty",
     as_files = ":empty",
@@ -143,6 +159,8 @@ cc_toolchain(
     objcopy_files = ":empty",
     strip_files = ":empty",
     supports_param_files = 1,
+    toolchain_config = ":stub_armeabi-v7a",
+    toolchain_identifier = "stub_armeabi-v7a",
 )
 
 armeabi_cc_toolchain_config(name = "stub_armeabi-v7a")

tools/cross-toolchain/configs/clang/bazel_2.1.1/config/BUILD

@@ -49,5 +49,5 @@ platform(
            name: "OSFamily"
            value:  "Linux"
         }
-        """, 
+        """,
 )

tools/cross-toolchain/configs/clang/bazel_2.1.1/prysm_toolchains/BUILD.bazel

@@ -4,7 +4,6 @@ load(":cc_toolchain_config_osx.bzl", "osx_cc_toolchain_config")
 load(":cc_toolchain_config_linux_arm64.bzl", "arm64_cc_toolchain_config")
 load(":cc_toolchain_config_windows.bzl", "windows_cc_toolchain_config")
 
-
 cc_toolchain_suite(
     name = "multiarch_toolchain",
     toolchains = {

tools/cross-toolchain/configs/clang/bazel_2.1.1/prysm_toolchains/cc_toolchain_config_linux_arm64.bzl

@@ -10,7 +10,6 @@ load(
     "tool_path",
     "with_feature_set",
 )
-
 load(
     "@bazel_tools//tools/cpp:cc_toolchain_config.bzl",
     ALL_COMPILE_ACTIONS = "all_compile_actions",

tools/cross-toolchain/configs/clang/bazel_2.1.1/prysm_toolchains/cc_toolchain_config_osx.bzl

@@ -10,7 +10,6 @@ load(
     "tool_path",
     "with_feature_set",
 )
-
 load(
     "@bazel_tools//tools/cpp:cc_toolchain_config.bzl",
     ALL_COMPILE_ACTIONS = "all_compile_actions",
@@ -142,10 +141,10 @@ def _impl(ctx):
                             "-lc++",
                             "-lc++abi",
                             "-F" + sdkroot + "System/Library/Frameworks/",
-                            "-L"+ sdkroot + "usr/lib",
+                            "-L" + sdkroot + "usr/lib",
                             "-undefined",
                             "dynamic_lookup",
-                            ],
+                        ],
                     ),
                 ],
             ),

tools/cross-toolchain/configs/clang/bazel_2.1.1/prysm_toolchains/cc_toolchain_config_windows.bzl

@@ -1,6 +1,9 @@
 load(
     "@bazel_tools//tools/cpp:cc_toolchain_config_lib.bzl",
     "action_config",
+    "artifact_name_pattern",
+    "env_entry",
+    "env_set",
     "feature",
     "feature_set",
     "flag_group",
@@ -9,18 +12,13 @@ load(
     "tool",
     "tool_path",
     "with_feature_set",
-    "artifact_name_pattern",
-    "env_set",
-    "env_entry",
 )
-
 load(
     "@bazel_tools//tools/cpp:cc_toolchain_config.bzl",
     ALL_COMPILE_ACTIONS = "all_compile_actions",
     ALL_CPP_COMPILE_ACTIONS = "all_cpp_compile_actions",
     ALL_LINK_ACTIONS = "all_link_actions",
 )
-
 load("@bazel_tools//tools/build_defs/cc:action_names.bzl", "ACTION_NAMES")
 
 def _impl(ctx):
@@ -39,7 +37,6 @@ def _impl(ctx):
     install = "/usr/x86_64-w64-mingw32/"
     bin_prefix = "/usr/bin/x86_64-w64-mingw32-"
 
-
     targets_windows_feature = feature(
         name = "targets_windows",
         implies = ["copy_dynamic_libraries_to_binary"],
@@ -85,8 +82,8 @@ def _impl(ctx):
         "-Wself-assign",
         "-x c++",
         "-lstdc++",
-        "-lpthread"
-        ]
+        "-lpthread",
+    ]
 
     msys_mingw_link_flags = [
         "-l:libstdc++.a",
@@ -116,7 +113,7 @@ def _impl(ctx):
                 ],
             ),
             flag_set(
-               actions = [
+                actions = [
                     ACTION_NAMES.linkstamp_compile,
                     ACTION_NAMES.cpp_compile,
                     ACTION_NAMES.cpp_header_parsing,
@@ -158,7 +155,7 @@ def _impl(ctx):
     ]
 
     cxx_builtin_include_directories = [
-        install +"include"
+        install + "include",
     ]
 
     artifact_name_patterns = [
@@ -210,4 +207,3 @@ windows_cc_toolchain_config = rule(
     },
     provides = [CcToolchainConfigInfo],
 )
-