Skip to content

Commit 78347d9

Browse files
authored
fix panel visualization preview, new viz workflow (opensearch-project#401)
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
1 parent 05ef180 commit 78347d9

File tree

3 files changed

+24
-3
lines changed

3 files changed

+24
-3
lines changed

public/components/custom_panels/custom_panel_view_so.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -127,6 +127,8 @@ interface CustomPanelViewProps {
127127
appId?: string;
128128
updateAvailabilityVizId?: any;
129129
onAddClick?: any;
130+
pplService: PPLService;
131+
dslService: DSLService;
130132
}
131133

132134
export const CustomPanelViewSO = (props: CustomPanelViewProps) => {

public/components/custom_panels/home.tsx

+2
Original file line numberDiff line numberDiff line change
@@ -237,6 +237,8 @@ export const Home = ({
237237
<CustomPanelViewSO
238238
panelId={props.match.params.id}
239239
chrome={chrome}
240+
pplService={pplService}
241+
dslService={dslService}
240242
parentBreadcrumbs={customPanelBreadCrumbs}
241243
deleteCustomPanel={deleteCustomPanel}
242244
setToast={setToast}

public/components/custom_panels/panel_modules/visualization_flyout/visualization_flyout_so.tsx

+20-3
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,12 @@ import React, { useEffect, useState } from 'react';
3737
import { v4 as uuidv4 } from 'uuid';
3838
import { useDispatch, useSelector } from 'react-redux';
3939
import { FlyoutContainers } from '../../../common/flyout_containers';
40-
import { displayVisualization, getQueryResponse, isDateValid } from '../../helpers/utils';
40+
import {
41+
displayVisualization,
42+
getQueryResponse,
43+
isDateValid,
44+
parseSavedVisualizations,
45+
} from '../../helpers/utils';
4146
import { convertDateTime } from '../../helpers/utils';
4247
import PPLService from '../../../../services/requests/ppl';
4348
import { CoreStart } from '../../../../../../../src/core/public';
@@ -53,6 +58,12 @@ import './visualization_flyout.scss';
5358
import { uiSettingsService } from '../../../../../common/utils';
5459
import { ILegacyScopedClusterClient } from '../../../../../../../src/core/server';
5560
import { replaceVizInPanel, selectPanel } from '../../redux/panel_slice';
61+
import { SavedObjectsActions } from '../../../../services/saved_objects/saved_object_client/saved_objects_actions';
62+
import {
63+
ObservabilitySavedObject,
64+
ObservabilitySavedVisualization,
65+
} from '../../../../services/saved_objects/saved_object_client/types';
66+
import { SAVED_VISUALIZATION } from '../../../../../common/constants/explorer';
5667

5768
/*
5869
* VisaulizationFlyoutSO - This module create a flyout to add visualization for SavedObjects custom Panels
@@ -351,8 +362,14 @@ export const VisaulizationFlyoutSO = ({
351362

352363
// Fetch all saved visualizations
353364
const fetchSavedVisualizations = async () => {
354-
return http
355-
.get(`${CUSTOM_PANELS_API_PREFIX}/visualizations`)
365+
return SavedObjectsActions.getBulk<ObservabilitySavedVisualization>({
366+
objectType: [SAVED_VISUALIZATION],
367+
sortOrder: 'desc',
368+
fromIndex: 0,
369+
})
370+
.then((response) => ({
371+
visualizations: response.observabilityObjectList.map(parseSavedVisualizations),
372+
}))
356373
.then((res) => {
357374
if (res.visualizations.length > 0) {
358375
setSavedVisualizations(res.visualizations);

0 commit comments

Comments
 (0)