Not getting cookies from localhost

[kraktus]

Hello,

This is a follow up on #4643, which was closed without a fix. The issue is that requests does not get cookies from localhost. I could reproduce on 2.26.0.

I'm reposting the POC from #4643 (comment), which was added after the issue was closed.

import pytest
import threading
import requests

from tests.testserver.server import Server, consume_socket_content

def test_cookie_set_for_localhost():

    def response_handler(sock):
        consume_socket_content(sock, timeout=0.5)
        host, port = sock.getsockname()
        sock.send(
            b'HTTP/1.1 200 OK\r\n'
            b'Content-Length: 0\r\n'
            b'Set-Cookie: foo=bar;   Max-Age=86400; Domain=localhost; Secure; HttpOnly\r\n\r\n'
            # b'Set-Cookie: foo=bar; Max-Age=86400; Domain=localhost:' + str(port).encode('ascii') + b'; Secure; HttpOnly\r\n\r\n' # does not help
        )

    close_server = threading.Event()
    server = Server(response_handler, wait_to_close_event=close_server)

    with server as (host, port):
        url = 'http://{0}:{1}/'.format(host, port)
        r = requests.get(url)

        assert r.status_code == 200

        print(host, port)

        # Verify we received our expected cookie
        assert r.cookies
        assert r.cookies.get('foo') == 'bar'

        close_server.set()

It is unclear how #5388 could get them.

[keddad]

I don't think this is actually request's bug. It looks like Python's CookieJar.extract_cookies doesn't parse them properly.

[keddad]

Ok, this is not a bug, this is a feature: https://stackoverflow.com/questions/1134290/cookies-on-localhost-with-explicit-domain/32210291#32210291

[kraktus]

Thanks for looking into the issue.

I doubt it’s a feature or the SoF answer is largely inaccurate since latest version of Chrome/FireFox andSafari stored the cookies on the website I had tested but requests did not.

[keddad]

I've opened a bug report and wrote a possible solution: https://bugs.python.org/issue46075
However, since this is, definitely not a requests bug, this issue should probably be closed

[kraktus]

Thank you 👍