Fix text with parentheses on text shaping (close #884) (#889)

Author: andersonhc

CHANGELOG.md

@@ -21,6 +21,7 @@ This can also be enabled programmatically with `warnings.simplefilter('default',
 * [`FPDF.write_html()`](https://py-pdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.write_html) now supports heading colors defined as attributes (_e.g._ `<h2 color="#00ff00">...`)
 ### Fixed
 * [`FPDF.image()`](https://py-pdf.github.io/fpdf2/fpdf/fpdf.html#fpdf.fpdf.FPDF.image), when provided a `BytesIO` instance, does not close it anymore - _cf._ issue [#881](https://github.com/py-pdf/fpdf2/issues/881)
+* Fix invalid characters being generated when a string contains parentheses - _cf._ issue [#884](https://github.com/py-pdf/fpdf2/issues/884)
 
 ## [2.7.5] - 2023-08-04
 ### Added

fpdf/line_break.py

@@ -275,7 +275,7 @@ def adjust_pos(pos):
             char = chr(ti["mapped_char"]).encode("utf-16-be").decode("latin-1")
             if ti["x_offset"] != 0 or ti["y_offset"] != 0:
                 if text:
-                    ret += f"({text}) Tj "
+                    ret += f"({escape_parens(text)}) Tj "
                     text = ""
                 offsetx = pos_x + adjust_pos(ti["x_offset"])
                 offsety = pos_y - adjust_pos(ti["y_offset"])
@@ -293,12 +293,12 @@ def adjust_pos(pos):
                 word_spacing and ti["mapped_char"] == space_mapped_code
             ):
                 if text:
-                    ret += f"({text}) Tj "
+                    ret += f"({escape_parens(text)}) Tj "
                     text = ""
                 ret += f"1 0 0 1 {(pos_x) * self.k:.2f} {(h - pos_y) * self.k:.2f} Tm "
 
         if text:
-            ret += f"({text}) Tj"
+            ret += f"({escape_parens(text)}) Tj"
         return ret
 
     def render_pdf_text_core(self, frag_ws, current_ws):

test/text_shaping/test_text_shaping.py

@@ -139,3 +139,15 @@ def test_features(tmp_path):
     pdf.ln()
 
     assert_pdf_equal(pdf, HERE / "features.pdf", tmp_path)
+
+
+def test_text_with_parentheses(tmp_path):
+    pdf = FPDF()
+    pdf.add_page()
+    pdf.add_font(family="SBL_Hbrw", fname=HERE / "SBL_Hbrw.ttf")
+    pdf.set_font("SBL_Hbrw", size=30)
+    pdf.set_text_shaping(30)
+    pdf.cell(txt="אנגלית (באנגלית: English) ה", new_x="LEFT", new_y="NEXT")
+    pdf.ln()
+    pdf.cell(txt="אנגלית (באנגלית: English) ", new_y="NEXT")
+    assert_pdf_equal(pdf, HERE / "text_with_parentheses.pdf", tmp_path)