-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional markdown support is missing in the 'multi_cell()' and 'write()' methods #171
Comments
Thanks for opening this PR to keep track of this. As mentioned in comment #108 (comment) Note that this feature is needed in order to properly fix issue #151 I have written some unit tests but I may not have the time to implement this soon. Pull requests are very welcome! |
Apologies, @Lucas-C -- I'd missed that comment. (I will take a look to see if I could help with the implementation, but I suspect there'll be too much of an FPDF learning curve for me to contribute efficiently.) |
There are some unit tests to get started: |
Hi Lucas-C, |
Agreed @YeshiNamkhai ! I probably won't tackle this one myself in the near future. |
Well, I have no time to get it work in the last release, but adding few lines already does the job, I 've tested with your example and within my project. So far it's working well with Google fonts and custom templates.
then inside the function add markdown=True
for every call of self.cell |
I am very surprised that it is actually as easy to implement 😲 When I worked on adding pseudo-Markdown support for Anyway, I added your suggestion, thank you @YeshiNamkhai ! |
Support for an optional
markdown
parameter was meant to have been added to thecell()
,multi_cell()
andwrite()
methods (issue #108, PR #154), to allow rendering of inline bold, italic (etc.) text within a cell.Support for the
markdown
parameter is present in thecell()
method, but is missing from themulti_cell()
andwrite()
methods in FPDF2 v2.4.1.Support is present in commit 508f39d, which is meant to be part of merged PR #154, but somehow this hasn't made it into the release.
The text was updated successfully, but these errors were encountered: