STY: Remove excluding Ruff rule RUF005 (#3186)

RUF005: Consider iterable unpacking instead of concatenation.

Author: j-t-1

pypdf/_page.py

@@ -622,9 +622,9 @@ def _get_ids_image(
             if not isinstance(x_object[o], StreamObject):
                 continue
             if x_object[o][IA.SUBTYPE] == "/Image":
-                lst.append(o if len(ancest) == 0 else ancest + [o])
+                lst.append(o if len(ancest) == 0 else [*ancest, o])
             else:  # is a form with possible images inside
-                lst.extend(self._get_ids_image(x_object[o], ancest + [o], call_stack))
+                lst.extend(self._get_ids_image(x_object[o], [*ancest, o], call_stack))
         assert self.inline_images is not None
         lst.extend(list(self.inline_images.keys()))
         return lst

pypdf/_writer.py

@@ -2074,11 +2074,13 @@ def remove_objects_from_page(
         jump_operators = []
         if to_delete & ObjectDeletionFlag.DRAWING_IMAGES:
             jump_operators = (
-                [b"w", b"J", b"j", b"M", b"d", b"i"]
-                + [b"W", b"W*"]
-                + [b"b", b"b*", b"B", b"B*", b"S", b"s", b"f", b"f*", b"F", b"n"]
-                + [b"m", b"l", b"c", b"v", b"y", b"h", b"re"]
-                + [b"sh"]
+                [
+                    b"w", b"J", b"j", b"M", b"d", b"i",
+                    b"W", b"W*",
+                    b"b", b"b*", b"B", b"B*", b"S", b"s", b"f", b"f*", b"F", b"n",
+                    b"m", b"l", b"c", b"v", b"y", b"h", b"re",
+                    b"sh"
+                ]
             )
         if to_delete & ObjectDeletionFlag.TEXT:
             jump_operators = [b"Tj", b"TJ", b"'", b'"']
@@ -2698,11 +2700,11 @@ def merge(
                 # numbers in the exclude list identifies that the exclusion is
                 # only applicable to 1st level of cloning
                 srcpages[pg.indirect_reference.idnum] = self.add_page(
-                    pg, list(excluded_fields) + [1, "/B", 1, "/Annots"]  # type: ignore
+                    pg, [*list(excluded_fields), 1, "/B", 1, "/Annots"]  # type: ignore
                 )
             else:
                 srcpages[pg.indirect_reference.idnum] = self.insert_page(
-                    pg, position, list(excluded_fields) + [1, "/B", 1, "/Annots"]  # type: ignore
+                    pg, position, [*list(excluded_fields), 1, "/B", 1, "/Annots"]  # type: ignore
                 )
                 position += 1
             srcpages[pg.indirect_reference.idnum].original_page = pg

pypdf/generic/_base.py

@@ -624,7 +624,7 @@ def write_to_stream(
         stream.write(b">")
 
     def __str__(self) -> str:
-        charset_to_try = ["utf-16"] + list(NameObject.CHARSETS)
+        charset_to_try = ["utf-16", *list(NameObject.CHARSETS)]
         for enc in charset_to_try:
             try:
                 return self.decode(enc)

pypdf/pagerange.py

@@ -173,7 +173,7 @@ def parse_filename_page_ranges(
     pairs: List[Tuple[str, PageRange]] = []
     pdf_filename: Union[str, None] = None
     did_page_range = False
-    for arg in args + [None]:
+    for arg in [*args, None]:
         if PageRange.valid(arg):
             if not pdf_filename:
                 raise ValueError(

pyproject.toml

@@ -188,7 +188,6 @@ ignore = [
     "RET508",  # Unnecessary `else` after `break` statement
     "RUF001",  # Detect confusable Unicode-to-Unicode units. Introduces bugs
     "RUF002",  # Detect confusable Unicode-to-Unicode units. Introduces bugs
-    "RUF005",  # Detect confusable Unicode-to-Unicode units. Introduces bugs
     "S101",    # Use of `assert` detected
     "S110",    # `try`-`except`-`pass` detected, consider logging the exception
     "SIM105",  # contextlib.suppress

tests/test_page_labels.py

@@ -135,7 +135,8 @@ def test_index2label_kids():
         "XV",
         "XVI",
         "XVII",
-    ] + list(map(str, range(1, 284)))
+        *list(map(str, range(1, 284)))
+    ]
     for x in ["20", "44", "58", "82", "94", "116", "154", "166", "192", "224", "250"]:
         # Some page labels are unused. Removing them is still easier than copying the
         # whole list itself here.