MAINT: Revert 92bb037 (#2961)

Undo PR: 92bb037

According to our deprecation policy, we would have to issue a new major release for that change.

Author: j-t-1

pypdf/_doc_common.py

@@ -49,7 +49,7 @@
 from ._page import PageObject, _VirtualList
 from ._page_labels import index2label as page_index2page_label
 from ._utils import (
-    deprecation_with_replacement,
+    deprecate_with_replacement,
     logger_warning,
     parse_iso8824_date,
 )
@@ -1281,10 +1281,10 @@ def decode_permissions(
         self, permissions_code: int
     ) -> Dict[str, bool]:  # pragma: no cover
         """Take the permissions as an integer, return the allowed access."""
-        deprecation_with_replacement(
+        deprecate_with_replacement(
             old_name="decode_permissions",
             new_name="user_access_permissions",
-            removed_in="6.0.0",
+            removed_in="5.0.0",
         )
 
         permissions_mapping = {

tests/test_reader.py

@@ -14,7 +14,6 @@
 from pypdf.constants import PageAttributes as PG
 from pypdf.constants import UserAccessPermissions as UAP
 from pypdf.errors import (
-    DeprecationError,
     EmptyFileError,
     FileNotDecryptedError,
     PdfReadError,
@@ -746,16 +745,16 @@ def test_decode_permissions():
     print_ = base.copy()
     print_["print"] = True
     with pytest.raises(
-        DeprecationError,
-        match="decode_permissions is deprecated and was removed in pypdf 6.0.0. Use user_access_permissions instead",
+        DeprecationWarning,
+        match="decode_permissions is deprecated and will be removed in pypdf 5.0.0. Use user_access_permissions instead",  # noqa: E501
     ):
         assert reader.decode_permissions(4) == print_
 
     modify = base.copy()
     modify["modify"] = True
     with pytest.raises(
-        DeprecationError,
-        match="decode_permissions is deprecated and was removed in pypdf 6.0.0. Use user_access_permissions instead",
+        DeprecationWarning,
+        match="decode_permissions is deprecated and will be removed in pypdf 5.0.0. Use user_access_permissions instead",  # noqa: E501
     ):
         assert reader.decode_permissions(8) == modify