Skip to content

Commit b256965

Browse files
authored
TST: Fix side effect #2379 (#2395)
Issue due to unclosure of temporary file Closes #2394
1 parent 85ab279 commit b256965

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

tests/test_writer.py

+9-7
Original file line numberDiff line numberDiff line change
@@ -224,7 +224,8 @@ def writer_operate(writer: PdfWriter) -> None:
224224
)
225225
def test_writer_operations_by_traditional_usage(convert, needs_cleanup):
226226
if callable(convert):
227-
write_data_here = convert(NamedTemporaryFile(suffix=".pdf", delete=False).name)
227+
with NamedTemporaryFile(suffix=".pdf", delete=False) as fo:
228+
write_data_here = convert(fo.name)
228229
else:
229230
write_data_here = convert
230231

@@ -254,7 +255,8 @@ def test_writer_operations_by_traditional_usage(convert, needs_cleanup):
254255
)
255256
def test_writer_operations_by_semi_traditional_usage(convert, needs_cleanup):
256257
if callable(convert):
257-
write_data_here = convert(NamedTemporaryFile(suffix=".pdf", delete=False).name)
258+
with NamedTemporaryFile(suffix=".pdf", delete=False) as fo:
259+
write_data_here = convert(fo.name)
258260
else:
259261
write_data_here = convert
260262

@@ -281,11 +283,10 @@ def test_writer_operations_by_semi_traditional_usage(convert, needs_cleanup):
281283
(BytesIO(), False),
282284
],
283285
)
284-
def test_writer_operations_by_semi_new_traditional_usage(
285-
convert, needs_cleanup
286-
):
286+
def test_writer_operations_by_semi_new_traditional_usage(convert, needs_cleanup):
287287
if callable(convert):
288-
write_data_here = convert(NamedTemporaryFile(suffix=".pdf", delete=False).name)
288+
with NamedTemporaryFile(suffix=".pdf", delete=False) as fo:
289+
write_data_here = convert(fo.name)
289290
else:
290291
write_data_here = convert
291292

@@ -309,7 +310,8 @@ def test_writer_operations_by_semi_new_traditional_usage(
309310
)
310311
def test_writer_operation_by_new_usage(convert, needs_cleanup):
311312
if callable(convert):
312-
write_data_here = convert(NamedTemporaryFile(suffix=".pdf", delete=False).name)
313+
with NamedTemporaryFile(suffix=".pdf", delete=False) as fo:
314+
write_data_here = convert(fo.name)
313315
else:
314316
write_data_here = convert
315317

0 commit comments

Comments
 (0)