Merge pull request #1086 from pybamm-team/issue-1080-require-t_eval

#1080 require t_eval

Author: valentinsulzer

CHANGELOG.md

@@ -8,7 +8,7 @@
 -   Added some new solvers for algebraic models ([#1059](https://github.com/pybamm-team/PyBaMM/pull/1059))
 -   Added `length_scales` attribute to models ([#1058](https://github.com/pybamm-team/PyBaMM/pull/1058))
 -   Added averaging in secondary dimensions ([#1057](https://github.com/pybamm-team/PyBaMM/pull/1057))
--   Added SEI reaction based on Yang et. al. 2017 and reduction in porosity ([#1009](https://github.com/pybamm-team/PyBaMM/issues/1009)) 
+-   Added SEI reaction based on Yang et. al. 2017 and reduction in porosity ([#1009](https://github.com/pybamm-team/PyBaMM/issues/1009))
 
 ## Optimizations
 
@@ -26,6 +26,8 @@
 
 ## Breaking changes
 
+-  The solution times `t_eval` must now be provided to `Simulation.solve()` when not using an experiment or prescribing the current using drive cycle data ([#1086](https://github.com/pybamm-team/PyBaMM/pull/1086))
+
 # [v0.2.2](https://github.com/pybamm-team/PyBaMM/tree/v0.2.2) - 2020-06-01
 
 New SEI models, simplification of submodel structure, as well as optimisations and general bug fixes.

README.md

@@ -13,9 +13,9 @@ PyBaMM (Python Battery Mathematical Modelling) solves physics-based electrochemi
 The easiest way to use PyBaMM is to run a 1C constant-current discharge with a model of your choice with all the default settings:
 ```python3
 import pybamm
-model = pybamm.lithium_ion.DFN() # Doyle-Fuller-Newman model
+model = pybamm.lithium_ion.DFN()  # Doyle-Fuller-Newman model
 sim = pybamm.Simulation(model)
-sim.solve()
+sim.solve([0, 3600])  # solve for 1 hour
 sim.plot()
 ```
 or simulate an experiment such as CCCV:
@@ -42,7 +42,7 @@ For new users we recommend the [Getting Started](examples/notebooks/Getting%20St
 
 Further details can be found in a number of [detailed examples](examples/notebooks/README.md), hosted here on
 github. In addition, there is a [full API documentation](http://pybamm.readthedocs.io/),
-hosted on [Read The Docs](readthedocs.io). 
+hosted on [Read The Docs](readthedocs.io).
 Additional supporting material can be found
 [here](https://github.com/pybamm-team/pybamm-supporting-material/).
 

examples/notebooks/Getting Started/Tutorial 1 - How to run a model.ipynb

@@ -72,7 +72,7 @@
    "cell_type": "markdown",
    "metadata": {},
    "source": [
-    "We can then call 'solve' on our simulation object to solve the model (by default the the model is solved for a 1C constant current discharge):"
+    "We can then call 'solve' on our simulation object to solve the model, passing the window of time to solve for in seconds (here 1 hour):"
    ]
   },
   {
@@ -83,7 +83,7 @@
     {
      "data": {
       "text/plain": [
-       "<pybamm.solvers.solution.Solution at 0x7fa3273a5a90>"
+       "<pybamm.solvers.solution.Solution at 0x7f09715ea9b0>"
       ]
      },
      "execution_count": 4,
@@ -92,7 +92,7 @@
     }
    ],
    "source": [
-    "sim.solve()"
+    "sim.solve([0, 3600])"
    ]
   },
   {
@@ -110,12 +110,12 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "1c41a48411a94ff9a6fc19096bb4a0f5",
+       "model_id": "06ae219fb8b94fa3aad3b8907a41ed27",
        "version_major": 2,
        "version_minor": 0
       },
       "text/plain": [
-       "interactive(children=(FloatSlider(value=0.0, description='t', max=3599.9999999999995, step=35.99999999999999),…"
+       "interactive(children=(FloatSlider(value=0.0, description='t', max=1.0, step=0.01), Output()), _dom_classes=('w…"
       ]
      },
      "metadata": {},
@@ -138,9 +138,9 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "PyBaMM development (env)",
+   "display_name": "Python 3",
    "language": "python",
-   "name": "pybamm-dev"
+   "name": "python3"
   },
   "language_info": {
    "codemirror_mode": {
@@ -152,7 +152,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.8"
+   "version": "3.6.9"
   }
  },
  "nbformat": 4,

examples/notebooks/Getting Started/Tutorial 2 - Compare models.ipynb

@@ -70,7 +70,7 @@
     "sims = []\n",
     "for model in models:\n",
     "    sim = pybamm.Simulation(model)\n",
-    "    sim.solve()\n",
+    "    sim.solve([0, 3600])\n",
     "    sims.append(sim)"
    ]
   },
@@ -89,12 +89,12 @@
     {
      "data": {
       "application/vnd.jupyter.widget-view+json": {
-       "model_id": "63e7fa6511714626abc1173c35aad054",
+       "model_id": "b1cbafe2711e4d91aec48dfe246967b3",
        "version_major": 2,
        "version_minor": 0
       },
       "text/plain": [
-       "interactive(children=(FloatSlider(value=0.0, description='t', max=3599.9999999999995, step=35.99999999999999),…"
+       "interactive(children=(FloatSlider(value=0.0, description='t', max=3600.0, step=36.0), Output()), _dom_classes=…"
       ]
      },
      "metadata": {},
@@ -103,7 +103,7 @@
     {
      "data": {
       "text/plain": [
-       "<pybamm.plotting.quick_plot.QuickPlot at 0x7f089bff9518>"
+       "<pybamm.plotting.quick_plot.QuickPlot at 0x7f6d7b415470>"
       ]
      },
      "execution_count": 4,
@@ -125,9 +125,9 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "PyBaMM development (env)",
+   "display_name": "Python 3",
    "language": "python",
-   "name": "pybamm-dev"
+   "name": "python3"
   },
   "language_info": {
    "codemirror_mode": {
@@ -139,7 +139,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.6.8"
+   "version": "3.6.9"
   }
  },
  "nbformat": 4,