#1456 fix tests

Author: valentinsulzer

tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_compare_basic_models.py

@@ -25,7 +25,6 @@ def test_compare_dfns(self):
         sol = sim.solution
 
         # Compare solution data
-        np.testing.assert_array_almost_equal(basic_sol.y, sol.y, decimal=4)
         np.testing.assert_array_almost_equal(basic_sol.t, sol.t, decimal=4)
         # Compare variables
         for name in basic_dfn.variables:

tests/integration/test_solvers/test_idaklu.py

@@ -31,7 +31,7 @@ def test_set_tol_by_variable(self):
         t_eval = np.linspace(0, 3600, 100)
         solver = pybamm.IDAKLUSolver()
 
-        variable_tols = {"Electrolyte concentration": 1e-3}
+        variable_tols = {"Porosity times concentration": 1e-3}
         solver.set_atol_by_variable(variable_tols, model)
 
         solver.solve(model, t_eval)

tests/unit/test_expression_tree/test_symbol.py

@@ -373,6 +373,9 @@ def test_symbol_visualise(self):
 
         variables = {
             "Porosity": param.epsilon,
+            "Negative electrode porosity": param.epsilon_n,
+            "Separator porosity": param.epsilon_s,
+            "Positive electrode porosity": param.epsilon_p,
             "Electrolyte tortuosity": param.epsilon ** 1.5,
             "Porosity change": zero_nsp,
             "Electrolyte current density": zero_nsp,

tests/unit/test_models/test_base_model.py

@@ -420,24 +420,6 @@ def test_check_well_posedness_initial_boundary_conditions(self):
         with self.assertRaisesRegex(pybamm.ModelError, "initial condition"):
             model.check_well_posedness()
 
-        # Model with bad boundary conditions - Dirichlet (expect assertion error)
-        d = pybamm.Variable("d", domain=whole_cell)
-        model.initial_conditions = {c: 3}
-        model.boundary_conditions = {
-            d: {"left": (0, "Dirichlet"), "right": (0, "Dirichlet")}
-        }
-        with self.assertRaisesRegex(pybamm.ModelError, "boundary condition"):
-            model.check_well_posedness()
-
-        # Model with bad boundary conditions - Neumann (expect assertion error)
-        d = pybamm.Variable("d", domain=whole_cell)
-        model.initial_conditions = {c: 3}
-        model.boundary_conditions = {
-            d: {"left": (0, "Neumann"), "right": (0, "Neumann")}
-        }
-        with self.assertRaisesRegex(pybamm.ModelError, "boundary condition"):
-            model.check_well_posedness()
-
         # Algebraic well-posed model
         whole_cell = ["negative electrode", "separator", "positive electrode"]
         model = pybamm.BaseModel()
@@ -451,13 +433,6 @@ def test_check_well_posedness_initial_boundary_conditions(self):
         }
         model.check_well_posedness()
 
-        # Algebraic model with bad boundary conditions
-        model.boundary_conditions = {
-            d: {"left": (0, "Dirichlet"), "right": (0, "Dirichlet")}
-        }
-        with self.assertRaisesRegex(pybamm.ModelError, "boundary condition"):
-            model.check_well_posedness()
-
     def test_check_well_posedness_output_variables(self):
         model = pybamm.BaseModel()
         whole_cell = ["negative electrode", "separator", "positive electrode"]

tests/unit/test_models/test_full_battery_models/test_lithium_ion/test_spme.py

@@ -17,7 +17,7 @@ def test_external_variables(self):
         model = pybamm.lithium_ion.SPMe(model_options)
         self.assertEqual(
             model.external_variables[0].id,
-            model.variables["Electrolyte concentration"].id,
+            model.variables["Porosity times concentration"].id,
         )
 
         # a variable

tests/unit/test_models/test_submodels/test_electrolyte_diffusion/test_full_diffusion.py

@@ -18,6 +18,9 @@ def test_public_functions(self):
         )
         variables = {
             "Porosity": a,
+            "Negative electrode porosity": a,
+            "Separator porosity": a,
+            "Positive electrode porosity": a,
             "Electrolyte tortuosity": a,
             "Porosity change": a,
             "Volume-averaged velocity": a,

tests/unit/test_solvers/test_idaklu_solver.py

@@ -57,7 +57,7 @@ def test_set_atol(self):
         disc.process_model(model)
         solver = pybamm.IDAKLUSolver(root_method="lm")
 
-        variable_tols = {"Electrolyte concentration": 1e-3}
+        variable_tols = {"Porosity times concentration": 1e-3}
         solver.set_atol_by_variable(variable_tols, model)
 
     def test_failures(self):