#775 fix tests

Author: valentinsulzer

pybamm/solvers/casadi_solver.py

@@ -266,7 +266,7 @@ def integrate_casadi(self, rhs, algebraic, y0, t_eval, inputs=None):
             y_casadi_w_ext = casadi.vertcat(y_diff, y_ext[len(y0) :])
             problem.update({"ode": rhs(t, y_casadi_w_ext, u)})
         else:
-            y_alg = self.y_alg
+            y_alg = casadi.MX.sym("y_alg", algebraic(0, y0_w_ext, u).shape[0])
             y_casadi_w_ext = casadi.vertcat(y_diff, y_alg, y_ext[len(y0) :])
             problem.update(
                 {

pybamm/solvers/dae_solver.py

@@ -340,8 +340,6 @@ def get_event_class(event):
         self.events = model.events
         self.event_funs = [get_event_class(event) for event in casadi_events.values()]
         self.jacobian = jacobian
-        self.y_diff = y_diff
-        self.y_alg = y_alg
 
         # Save CasADi functions for the CasADi solver
         # Note: when we pass to casadi the ode part of the problem must be in explicit

pybamm/solvers/ode_solver.py

@@ -232,8 +232,6 @@ def get_event_class(event):
 
         # Add the solver attributes
         self.y0 = y0
-        self.y_diff = y_casadi
-        self.y_casadi_w_ext = y_casadi_w_ext
         self.dydt = DydtCasadi(model, concatenated_rhs_fn)
         self.events = model.events
         self.event_funs = [get_event_class(event) for event in casadi_events.values()]

tests/unit/test_solvers/test_ode_solver.py

@@ -14,9 +14,13 @@ def test_exceptions(self):
     def test_wrong_solver(self):
         # Create model
         model = pybamm.BaseModel()
-        var = pybamm.Variable("var")
-        model.rhs = {var: var}
-        model.algebraic = {var: var - 1}
+        var1 = pybamm.Variable("var1")
+        var2 = pybamm.Variable("var2")
+        model.rhs = {var1: var1}
+        model.algebraic = {var2: var2 - 1}
+        model.initial_conditions = {var1: 0, var2: 1}
+        disc = pybamm.Discretisation()
+        disc.process_model(model)
 
         # test errors
         solver = pybamm.OdeSolver()