#729 events fix

Author: valentinsulzer

examples/scripts/ecker_set.py

@@ -1,16 +1,18 @@
 import pybamm as pb
+import numpy as np
 
-pb.set_logging_level("DEBUG")
+pb.set_logging_level("INFO")
 
 model = pb.lithium_ion.DFN()
-# model.convert_to_format = "python"
+model.convert_to_format = "python"
 
 chemistry = pb.parameter_sets.Ecker2015
 # chemistry = pb.parameter_sets.Marquis2019
 parameter_values = pb.ParameterValues(chemistry=chemistry)
 
 sim = pb.Simulation(model, parameter_values=parameter_values)
 
-solver = pb.CasadiSolver(mode="safe")
-sim.solve(solver=solver)
-
+solver = pb.IDAKLUSolver()  # mode="fast")
+t_eval = np.linspace(0, 1, 100)
+sim.solve(t_eval=t_eval, solver=solver)
+sim.plot()

pybamm/expression_tree/scalar.py

@@ -2,6 +2,7 @@
 # Scalar class
 #
 import pybamm
+import numpy as np
 
 
 class Scalar(pybamm.Symbol):
@@ -40,7 +41,7 @@ def value(self):
 
     @value.setter
     def value(self, value):
-        self._value = float(value)
+        self._value = np.float64(value)
 
     def set_id(self):
         """ See :meth:`pybamm.Symbol.set_id()`. """