Skip to content

Commit 687dff4

Browse files
Merge a7043df into 2c223ba
2 parents 2c223ba + a7043df commit 687dff4

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

+1
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@
3131

3232
## Bug fixes
3333

34+
- Fixed a sign error in the positive electrode ohmic losses ([#1407](https://github.com/pybamm-team/PyBaMM/pull/1407))
3435
- Simulations now stop when an experiment becomes infeasible ([#1395](https://github.com/pybamm-team/PyBaMM/pull/1395))
3536
- Added a check for domains in `Concatenation` ([#1368](https://github.com/pybamm-team/PyBaMM/pull/1368))
3637
- Differentiation now works even when the differentiation variable is a constant ([#1294](https://github.com/pybamm-team/PyBaMM/pull/1294))

pybamm/models/submodels/electrode/base_electrode.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ def _get_standard_potential_variables(self, phi_s):
5353
phi_s_av_dim = param.U_p_ref - param.U_n_ref + pot * phi_s_av
5454

5555
v = pybamm.boundary_value(phi_s, "right")
56-
delta_phi_s = phi_s - v
56+
delta_phi_s = v - phi_s
5757
delta_phi_s_av = pybamm.x_average(delta_phi_s)
5858
delta_phi_s_dim = delta_phi_s * pot
5959
delta_phi_s_av_dim = delta_phi_s_av * pot

0 commit comments

Comments
 (0)