Skip to content

Commit d18cf81

Browse files
committed
#1477 fix idaklu unit test
1 parent 073eb58 commit d18cf81

File tree

3 files changed

+6
-9
lines changed

3 files changed

+6
-9
lines changed

pybamm/solvers/solution.py

+5-2
Original file line numberDiff line numberDiff line change
@@ -261,8 +261,11 @@ def y(self):
261261
@property
262262
def sensitivities(self):
263263
"""Values of the sensitivities. Returns a dict of param_name: np_array"""
264-
if isinstance(self._sensitivities, bool) and self._sensitivities:
265-
self.extract_explicit_sensitivities()
264+
if isinstance(self._sensitivities, bool):
265+
if self._sensitivities:
266+
self.extract_explicit_sensitivities()
267+
else:
268+
self._sensitivities = {}
266269
return self._sensitivities
267270

268271
def set_y(self):

tests/integration/test_models/test_full_battery_models/test_lithium_ion/test_spm.py

-7
Original file line numberDiff line numberDiff line change
@@ -23,14 +23,7 @@ def test_sensitivities(self):
2323
param = pybamm.ParameterValues(chemistry=pybamm.parameter_sets.Ecker2015)
2424
modeltest = tests.StandardModelTest(model, parameter_values=param)
2525
modeltest.test_sensitivities(
26-
#"Negative electrode conductivity [S.m-1]", 14.0
2726
'Typical current [A]', 0.15652,
28-
#"Typical electrolyte concentration [mol.m-3]", 1000.0
29-
#''Negative electrode diffusivity [m2.s-1]', 1e-3,
30-
#'Negative electrode active material volume fraction', 0.372403,
31-
#'Separator thickness [m]', 2e-05,
32-
#'Negative electrode electrons in reaction', 1.0,
33-
#'Outer SEI open-circuit potential [V]', 0.8,
3427
)
3528

3629
def test_basic_processing_1plus1D(self):

tests/unit/test_solvers/test_idaklu_solver.py

+1
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,7 @@ def test_ida_roberts_klu_sensitivities(self):
110110
sol_plus = solver.solve(model, t_eval, inputs={"a": a_value + 0.5 * h})
111111
sol_neg = solver.solve(model, t_eval, inputs={"a": a_value - 0.5 * h})
112112
dyda_fd = (sol_plus.y - sol_neg.y) / h
113+
dyda_fd = dyda_fd.transpose().reshape(-1, 1)
113114

114115
np.testing.assert_array_almost_equal(
115116
dyda_ida, dyda_fd

0 commit comments

Comments
 (0)