#1100 merge develop

Author: valentinsulzer

pybamm/solvers/casadi_solver.py

@@ -299,11 +299,8 @@ def event_fun(t):
 
                     # assign temporary solve time
                     current_step_sol.solve_time = np.nan
-                    if solution is None:
-                        solution = current_step_sol
-                    else:
-                        # append solution from the current step to solution
-                        solution.append(current_step_sol)
+                    # append solution from the current step to solution
+                    solution.append(current_step_sol)
                     solution.termination = "event"
                     solution.t_event = t_event
                     solution.y_event = y_event

tests/unit/test_solvers/test_casadi_solver.py

@@ -306,6 +306,16 @@ def test_model_solver_with_inputs(self):
         self.assertLess(len(solution.t), len(t_eval))
         np.testing.assert_allclose(solution.y[0], np.exp(-0.1 * solution.t), rtol=1e-04)
 
+        # Without grid
+        solver = pybamm.CasadiSolver(mode="safe without grid", rtol=1e-8, atol=1e-8)
+        t_eval = np.linspace(0, 10, 100)
+        solution = solver.solve(model, t_eval, inputs={"rate": 0.1})
+        self.assertLess(len(solution.t), len(t_eval))
+        np.testing.assert_allclose(solution.y[0], np.exp(-0.1 * solution.t), rtol=1e-04)
+        solution = solver.solve(model, t_eval, inputs={"rate": 1.1})
+        self.assertLess(len(solution.t), len(t_eval))
+        np.testing.assert_allclose(solution.y[0], np.exp(-1.1 * solution.t), rtol=1e-04)
+
     def test_model_solver_dae_inputs_in_initial_conditions(self):
         # Create model
         model = pybamm.BaseModel()