Skip to content

Commit e07b0c4

Browse files
#802 fix basic dfn
1 parent f50fcc4 commit e07b0c4

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

pybamm/models/full_battery_models/lithium_ion/basic_dfn.py

+9-3
Original file line numberDiff line numberDiff line change
@@ -100,9 +100,15 @@ def __init__(self, name="Doyle-Fuller-Newman model"):
100100
# Porosity
101101
# Primary broadcasts are used to broadcast scalar quantities across a domain
102102
# into a vector of the right shape, for multiplying with other vectors
103-
eps_n = pybamm.PrimaryBroadcast(param.epsilon_n, "negative electrode")
104-
eps_s = pybamm.PrimaryBroadcast(param.epsilon_s, "separator")
105-
eps_p = pybamm.PrimaryBroadcast(param.epsilon_p, "positive electrode")
103+
eps_n = pybamm.PrimaryBroadcast(
104+
pybamm.Parameter("Negative electrode porosity"), "negative electrode"
105+
)
106+
eps_s = pybamm.PrimaryBroadcast(
107+
pybamm.Parameter("Separator porosity"), "separator"
108+
)
109+
eps_p = pybamm.PrimaryBroadcast(
110+
pybamm.Parameter("Positive electrode porosity"), "positive electrode"
111+
)
106112
eps = pybamm.Concatenation(eps_n, eps_s, eps_p)
107113

108114
# Tortuosity

0 commit comments

Comments
 (0)