Examine usage of repo-review tools as pre-commit hooks

[agriyakhetarpal]

To be picked as a follow-up to #3489 and #4887, this will help enforce rules around typing and check if our config is in the right place, etc. The pre-commit hook's speed must be investigated; extra thoughts are welcomed.

[Saransh-cpp]

Just to be clear, I think this issue is independent of the issues mentioned above, and ideally, the hook should be added to the repository as soon as possible (priority is still low). We can ignore the checks that are failing right now, and then slowly un-ignore them as part of #3489.

[agriyakhetarpal]

Sounds good to me, thanks for clarifying – I was under the impression that you want existing tests to pass first (or with the process of adding it).

[medha-14]

I benchmarked this, and the results are as follows:

Without the hook:

With the hook:

[Saransh-cpp]

Could you please ignore the failed checks in pyproject.toml for the time being and make this hook pass?

[agriyakhetarpal]

The speed is reasonable, too. We should be fine with adding it, I guess.

[Saransh-cpp]

Ah, I did not think about the speed at all. It should not matter if it takes a few more seconds!

[medha-14]

Could you please ignore the failed checks in pyproject.toml for the time being and make this hook pass?

Sure!