Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve shape tests for 2plus1D #527

Closed
rtimms opened this issue Jul 10, 2019 · 1 comment · Fixed by #552
Closed

improve shape tests for 2plus1D #527

rtimms opened this issue Jul 10, 2019 · 1 comment · Fixed by #552
Assignees

Comments

@rtimms
Copy link
Contributor

rtimms commented Jul 10, 2019

Sometimes shape test gives an error because the domain of a variable isn't set to current collector in 2D, when it should be. In practice the object ends up being the correct shape, just the domain it is labelled with is wrong. e.g. in inverse_butler_volmer the line eta_r = (2 / ne) * pybamm.Function(np.arcsinh, j / (2 * j0)) gives a shape error. j has the expected shape, but j0 doesn't as it contains a broadcast whose child had domain [] but should be ["current collector"]

@valentinsulzer valentinsulzer self-assigned this Jul 22, 2019
@valentinsulzer
Copy link
Member

I've fixed this in #546 (I think)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants