You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Sometimes shape test gives an error because the domain of a variable isn't set to current collector in 2D, when it should be. In practice the object ends up being the correct shape, just the domain it is labelled with is wrong. e.g. in inverse_butler_volmer the line eta_r = (2 / ne) * pybamm.Function(np.arcsinh, j / (2 * j0)) gives a shape error. j has the expected shape, but j0 doesn't as it contains a broadcast whose child had domain [] but should be ["current collector"]
The text was updated successfully, but these errors were encountered:
Sometimes shape test gives an error because the domain of a variable isn't set to current collector in 2D, when it should be. In practice the object ends up being the correct shape, just the domain it is labelled with is wrong. e.g. in
inverse_butler_volmer
the lineeta_r = (2 / ne) * pybamm.Function(np.arcsinh, j / (2 * j0))
gives a shape error.j
has the expected shape, butj0
doesn't as it contains a broadcast whose child had domain[]
but should be["current collector"]
The text was updated successfully, but these errors were encountered: