You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
1. Manually review the generated stubs in {stub_dir}
2. Run tests locally if you want (see CONTRIBUTING.md)
3. Commit the changes on a new branch and create a typeshed PR
The CI will check everything anyway, and is set up so that you don't have to run anything locally. This would also be consistent with CONTRIBUTING.md.
One problem with the generated stubs were overzealous re-exports. Is this still an issue? In that case we should probably mention it. But +1 from me.
This is definitely still an issue. But @hauntsaninja mentioned to me recently that this can probably be fixed just by passing the --export-less argument to stubgen. We should see if that fixes the problem — if so, there's no need to mention it to contributors in the create_baseline_stubs.py instructions.
I would prefer:
The CI will check everything anyway, and is set up so that you don't have to run anything locally. This would also be consistent with CONTRIBUTING.md.
Originally posted by @Akuli in #8686 (comment)
The text was updated successfully, but these errors were encountered: