Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we still need dill? #1267

Closed
renatomello opened this issue Mar 14, 2024 · 5 comments · Fixed by #1270
Closed

Do we still need dill? #1267

renatomello opened this issue Mar 14, 2024 · 5 comments · Fixed by #1270
Assignees
Labels
question Further information is requested
Milestone

Comments

@renatomello
Copy link
Contributor

@scarrazza @alecandido I spoke with @stavros11 and he said that dill was a solution for a problem that doesn't apply anymore. It is not used anywhere besides pyproject.toml and test_dill.py

@renatomello renatomello added the question Further information is requested label Mar 14, 2024
@stavros11
Copy link
Member

The problem I was referring to was the jupyter notebook runtime submission to slurm nodes, which I believe is not maintained anymore. I do not recall any other application of dill from our side.

@alecandido
Copy link
Member

The submission has been replaced by the serialization and the new qibo-client based on it.

I'd say that dill is not required any longer, though consider that serialization is currently limited, waiting for a general gate refactor (I will try to start it after qibo-core initial adoption), and I'm not sure if Hamiltonians and symbols are actually supported (but most likely they are not even used).

@scarrazza
Copy link
Member

My recollection is similar to @stavros11, at this stage, we don't need dill anymore including serialization as mentioned by @alecandido.

@renatomello
Copy link
Contributor Author

and I'm not sure if Hamiltonians and symbols are actually supported (but most likely they are not even used).

What do you mean by not even used?

@alecandido
Copy link
Member

For remote execution

@renatomello renatomello added this to the Qibo 0.2.7 milestone Mar 18, 2024
@renatomello renatomello self-assigned this Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants