Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent pytest results on macos with pytorch #1313

Closed
scarrazza opened this issue Apr 30, 2024 · 1 comment · Fixed by #1317
Closed

Inconsistent pytest results on macos with pytorch #1313

scarrazza opened this issue Apr 30, 2024 · 1 comment · Fixed by #1317
Assignees

Comments

@scarrazza
Copy link
Member

Tests are failing on macos after merging 036e882. The issue seems unrelated to code changes. I am able to reproduce the failure on macos, while it works well on linux.

@alecandido
Copy link
Member

This seems to be related to the generation of pRNG sequences with Pytorch. We need to reproduce the different sequence outside Qibo (the numbers that are then used within Qibo, leading to the discrepancy) and test on the different platforms, to understand which is the origin of the issue.

The current advice is to skip the affected test.

Moreover, in general is a good idea if our tests do not depend (much) on the seed used, testing statistical properties within suitable uncertainties (though it is always possible that an extraction falls outside one sigma).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants