Skip to content

Commit 546922c

Browse files
committedApr 5, 2023
Upgrade the reference oracle database container used across integration tests
1 parent 398e845 commit 546922c

File tree

11 files changed

+20
-16
lines changed

11 files changed

+20
-16
lines changed
 

‎build-parent/pom.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@
9494
<db2.image>docker.io/ibmcom/db2:11.5.7.0a</db2.image>
9595
<mssql.image>mcr.microsoft.com/mssql/server:2019-latest</mssql.image>
9696
<mysql.image>docker.io/mysql:8.0</mysql.image>
97-
<oracle.image>docker.io/gvenzl/oracle-xe:21-slim-faststart</oracle.image>
97+
<oracle.image>docker.io/gvenzl/oracle-free:23.2.0-faststart</oracle.image>
9898
<mongo.image>docker.io/mongo:4.4</mongo.image>
9999

100100
<!-- Align various dependencies that are not really part of the bom-->

‎extensions/devservices/oracle/src/main/java/io/quarkus/devservices/oracle/deployment/OracleDevServicesProcessor.java

+6-2
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@ public class OracleDevServicesProcessor {
2929

3030
private static final Logger LOG = Logger.getLogger(OracleDevServicesProcessor.class);
3131

32-
public static final String IMAGE = "gvenzl/oracle-xe";
32+
/**
33+
* This is the container name as defined by the Testcontainer's OracleContainer:
34+
* does not necessarily match the container name that Quarkus will default to use.
35+
*/
36+
public static final String ORIGINAL_IMAGE_NAME = "gvenzl/oracle-xe";
3337
public static final int PORT = 1521;
3438

3539
@BuildStep
@@ -91,7 +95,7 @@ public QuarkusOracleServerContainer(Optional<String> imageName, OptionalInt fixe
9195
boolean useSharedNetwork) {
9296
super(DockerImageName
9397
.parse(imageName.orElseGet(() -> ConfigureUtil.getDefaultImageNameFor("oracle")))
94-
.asCompatibleSubstituteFor(OracleDevServicesProcessor.IMAGE));
98+
.asCompatibleSubstituteFor(OracleDevServicesProcessor.ORIGINAL_IMAGE_NAME));
9599
this.fixedExposedPort = fixedExposedPort;
96100
this.useSharedNetwork = useSharedNetwork;
97101
}

‎extensions/reactive-oracle-client/deployment/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<name>Quarkus - Reactive Oracle Client - Deployment</name>
1616

1717
<properties>
18-
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521:XE</reactive-oracledb.url>
18+
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521/FREEPDB1</reactive-oracledb.url>
1919
</properties>
2020

2121
<dependencies>
@@ -131,7 +131,7 @@
131131
</property>
132132
</activation>
133133
<properties>
134-
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521:XE</reactive-oracledb.url>
134+
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521/FREEPDB1</reactive-oracledb.url>
135135
</properties>
136136
<build>
137137
<plugins>

‎extensions/reactive-oracle-client/deployment/src/test/java/io/quarkus/reactive/oracle/client/ReactiveOracleReloadTest.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ public class ReactiveOracleReloadTest {
1616
.add(new StringAsset("quarkus.datasource.db-kind=oracle\n" +
1717
"quarkus.datasource.username=SYSTEM\n" +
1818
"quarkus.datasource.password=hibernate_orm_test\n" +
19-
"quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@localhost:2115:XE"),
19+
"quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@localhost:2115/FREEPDB1"),
2020
"application.properties"));
2121

2222
@Test
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
quarkus.datasource.db-kind=oracle
22
quarkus.datasource.credentials-provider=custom
3-
quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@test:12345:XE
3+
quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@test:12345/FREEPDB1
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,9 @@
11
quarkus.datasource.db-kind=oracle
22
quarkus.datasource.username=SYSTEM
33
quarkus.datasource.password=hibernate_orm_test
4-
quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@test:12345:XE
4+
quarkus.datasource.reactive.url=vertx-reactive:oracle:thin:@test:12345/FREEPDB1
55

66
quarkus.datasource."hibernate".db-kind=oracle
77
quarkus.datasource."hibernate".username=SYSTEM
88
quarkus.datasource."hibernate".password=hibernate_orm_test
9-
quarkus.datasource."hibernate".reactive.url=vertx-reactive:oracle:thin:@test:55555:XE
9+
quarkus.datasource."hibernate".reactive.url=vertx-reactive:oracle:thin:@test:55555/FREEPDB1

‎integration-tests/jpa-oracle/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ Authentication parameters might need to be changed in the Quarkus configuration
2222
### Starting Oracle via docker
2323

2424
```
25-
docker run --memory-swappiness=0 --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-xe:21-slim-faststart
25+
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23.2.0-faststart
2626
```
2727

2828
This will start a local instance with the configuration matching the parameters used by the integration tests of this module.

‎integration-tests/jpa-oracle/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414
<description>Module that contains JPA related tests running with the Oracle database</description>
1515

1616
<properties>
17-
<oracledb.url>jdbc:oracle:thin:@localhost:1521/XE</oracledb.url>
17+
<oracledb.url>jdbc:oracle:thin:@localhost:1521/FREEPDB1</oracledb.url>
1818
</properties>
1919

2020
<dependencies>
@@ -187,7 +187,7 @@
187187
</property>
188188
</activation>
189189
<properties>
190-
<oracledb.url>jdbc:oracle:thin:@localhost:1521/XE</oracledb.url>
190+
<oracledb.url>jdbc:oracle:thin:@localhost:1521/FREEPDB1</oracledb.url>
191191
</properties>
192192
<build>
193193
<plugins>

‎integration-tests/opentelemetry-jdbc-instrumentation/src/test/java/io/quarkus/it/opentelemetry/OracleLifecycleManager.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ public class OracleLifecycleManager implements QuarkusTestResourceLifecycleManag
1010
@Override
1111
public Map<String, String> start() {
1212
Map<String, String> properties = new HashMap<>();
13-
properties.put("quarkus.datasource.oracle.jdbc.url", "jdbc:oracle:thin:@localhost:1521/XE");
13+
properties.put("quarkus.datasource.oracle.jdbc.url", "jdbc:oracle:thin:@localhost:1521/FREEPDB1");
1414
properties.put("quarkus.datasource.oracle.password", "quarkus");
1515
properties.put("quarkus.datasource.oracle.username", "SYSTEM");
1616
properties.put("quarkus.hibernate-orm.oracle.database.generation", "drop-and-create");

‎integration-tests/reactive-oracle-client/README.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ Authentication parameters might need to be changed in the Quarkus configuration
2323
### Starting Oracle via docker
2424

2525
```
26-
docker run --memory-swappiness=0 --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-xe:21-slim-faststart
26+
docker run --rm=true --name=HibernateTestingOracle -p 1521:1521 -e ORACLE_PASSWORD=hibernate_orm_test docker.io/gvenzl/oracle-free:23.2.0-faststart
2727
```
2828

2929
This will start a local instance with the configuration matching the parameters used by the integration tests of this module.

‎integration-tests/reactive-oracle-client/pom.xml

+2-2
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<name>Quarkus - Integration Tests - Reactive Oracle Client</name>
1616

1717
<properties>
18-
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521:XE</reactive-oracledb.url>
18+
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521/FREEPDB1</reactive-oracledb.url>
1919
</properties>
2020

2121
<dependencies>
@@ -152,7 +152,7 @@
152152
</property>
153153
</activation>
154154
<properties>
155-
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521:XE</reactive-oracledb.url>
155+
<reactive-oracledb.url>vertx-reactive:oracle:thin:@localhost:1521/FREEPDB1</reactive-oracledb.url>
156156
</properties>
157157
<build>
158158
<plugins>

0 commit comments

Comments
 (0)
Please sign in to comment.