You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I want to suggest an enhancement to how dependencies are identified in the dev_package_deps function. Currently, Additional_repositories are always added to repos:
which might be problematic when preparing CRAN releases. Always appending Additional_repositories to the repos, means that non-CRAN repos will be used for identifying Imports/Depends dependencies when testing the package on CI/CD. Such behaviour is not allowed when undergoing CRAN checks, as only Suggests packages are allowed to pull from Additional_repositories then.
Therefore I'd like to suggest adding a parameter which would make Additional_repositories conditional on a parameter.
I'll prepare a PR adding this parameter
The text was updated successfully, but these errors were encountered:
Hi,
I want to suggest an enhancement to how dependencies are identified in the
dev_package_deps
function. Currently,Additional_repositories
are always added to repos:remotes/R/deps.R
Line 130 in 6fe8836
which might be problematic when preparing CRAN releases. Always appending
Additional_repositories
to the repos, means that non-CRAN repos will be used for identifying Imports/Depends dependencies when testing the package on CI/CD. Such behaviour is not allowed when undergoing CRAN checks, as only Suggests packages are allowed to pull fromAdditional_repositories
then.Therefore I'd like to suggest adding a parameter which would make
Additional_repositories
conditional on a parameter.I'll prepare a PR adding this parameter
The text was updated successfully, but these errors were encountered: