Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make parsing Additional_repositories optional #782

Closed
maksymiuks opened this issue Feb 26, 2024 · 2 comments
Closed

Make parsing Additional_repositories optional #782

maksymiuks opened this issue Feb 26, 2024 · 2 comments

Comments

@maksymiuks
Copy link
Contributor

Hi,

I want to suggest an enhancement to how dependencies are identified in the dev_package_deps function. Currently, Additional_repositories are always added to repos:

repos <- c(repos, parse_additional_repositories(pkg))

which might be problematic when preparing CRAN releases. Always appending Additional_repositories to the repos, means that non-CRAN repos will be used for identifying Imports/Depends dependencies when testing the package on CI/CD. Such behaviour is not allowed when undergoing CRAN checks, as only Suggests packages are allowed to pull from Additional_repositories then.

Therefore I'd like to suggest adding a parameter which would make Additional_repositories conditional on a parameter.

I'll prepare a PR adding this parameter

@maksymiuks
Copy link
Contributor Author

PR ready #783

@maksymiuks
Copy link
Contributor Author

maksymiuks commented Feb 26, 2024

Closing as the PR was merged, thanks for the fast processing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant