Remove compilation digest file if webpack command fails (#1399)

Author: rossta

lib/webpacker/compiler.rb

@@ -19,7 +19,9 @@ def initialize(webpacker)
   def compile
     if stale?
       record_compilation_digest
-      run_webpack
+      run_webpack.tap do |success|
+        remove_compilation_digest if !success
+      end
     else
       true
     end
@@ -50,6 +52,10 @@ def record_compilation_digest
       compilation_digest_path.write(watched_files_digest)
     end
 
+    def remove_compilation_digest
+      compilation_digest_path.delete if compilation_digest_path.exist?
+    end
+
     def run_webpack
       logger.info "Compiling…"
 

test/compiler_test.rb

@@ -1,12 +1,20 @@
 require "test_helper"
 
 class CompilerTest < Minitest::Test
-  def setup
+  def remove_compilation_digest_path
     Webpacker.compiler.send(:compilation_digest_path).tap do |path|
       path.delete if path.exist?
     end
   end
 
+  def setup
+    remove_compilation_digest_path
+  end
+
+  def teardown
+    remove_compilation_digest_path
+  end
+
   def test_custom_environment_variables
     assert Webpacker.compiler.send(:webpack_env)["FOO"] == nil
     Webpacker.compiler.env["FOO"] = "BAR"
@@ -29,6 +37,27 @@ def test_freshness
     assert !Webpacker.compiler.fresh?
   end
 
+  def test_freshness_on_compile_success
+    status = OpenStruct.new(success?: true)
+
+    assert Webpacker.compiler.stale?
+    Open3.stub :capture3, [:sterr, :stdout, status] do
+      Webpacker.compiler.compile
+      assert Webpacker.compiler.fresh?
+    end
+  end
+
+  def test_staleness_on_compile_fail
+    status = OpenStruct.new(success?: false)
+
+    assert Webpacker.compiler.stale?
+    Open3.stub :capture3, [:sterr, :stdout, status] do
+
+      Webpacker.compiler.compile
+      assert Webpacker.compiler.stale?
+    end
+  end
+
   def test_compilation_digest_path
     assert Webpacker.compiler.send(:compilation_digest_path).to_s.ends_with?(Webpacker.env)
   end