Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update import paths for github.com/devfile/api to github.com/devfile/api/v2 #4346

Closed
johnmcollier opened this issue Jan 5, 2021 · 5 comments · Fixed by #4446
Closed

Update import paths for github.com/devfile/api to github.com/devfile/api/v2 #4346

johnmcollier opened this issue Jan 5, 2021 · 5 comments · Fixed by #4446
Assignees
Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/task Issue is actionable task priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).

Comments

@johnmcollier
Copy link
Member

We've recently updated the module path for the github.com/devfile/api Go module to now be github.com/devfile/api/v2, to enable us to release tagged versions of the Go module that match the Devfile schema's version (e.g. module version v2.0.0 for a 2.0.0 schema version). Some discussion on why this was needed can be found here.

This doesn't need to be done immediately, but once a new version of the devfile api is pulled into odo, the import paths for the Devfile API package that odo uses will need to be updated to change instances of import github.com/devfile/api/pkg... in odo to import github.com/devfile/api/v2/pkg.... (e.g. in https://github.com/openshift/odo/blob/adaa1b44e8de5ab0aa0d357294174f8efb8bdd24/pkg/odo/cli/storage/create.go#L7 and https://github.com/openshift/odo/blob/526ce0af8ce506ea4709595a5a9abb160ea3abe1/pkg/url/status_test.go#L8, among other instances)

@kadel
Copy link
Member

kadel commented Jan 6, 2021

/priority high
/area dependency
/kind task

@openshift-ci-robot openshift-ci-robot added priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)). area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs kind/task Issue is actionable task labels Jan 6, 2021
@dharmit
Copy link
Member

dharmit commented Feb 2, 2021

/good-first-issue

@openshift-ci-robot
Copy link
Collaborator

@dharmit:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Feb 2, 2021
@dharmit
Copy link
Member

dharmit commented Feb 8, 2021

This will most likely get addressed as a part of what I'm doing on #4160 to add CRD to devfile when user does odo service create.

@mik-dass mik-dass self-assigned this Feb 17, 2021
@mik-dass mik-dass removed the good first issue Denotes an issue ready for a new contributor. Maintainers will help mentor new contributors. label Feb 18, 2021
@mik-dass
Copy link
Contributor

This is a breaking change and many apis have changed in the latest version of the library. Thus a lot of our code base need to change including many unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Issues or PRs related to dependency changes. This label is also used on all Dependabot PRs help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/task Issue is actionable task priority/High Important issue; should be worked on before any other issues (except priority/Critical issue(s)).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants