file associations should be unique by pattern, not system id

Fixes #1053

Signed-off-by: David Thompson <davthomp@redhat.com>

Author: datho7561

src/api/xmlExtensionApiImplementation.ts

@@ -43,7 +43,7 @@ export function getXmlExtensionApiImplementation(languageClient: LanguageClient,
     addXMLFileAssociations: (fileAssociations: XMLFileAssociation[]) => {
       const externalfileAssociations = externalXmlSettings.xmlFileAssociations;
       fileAssociations.forEach(element => {
-        if (!externalfileAssociations.some(fileAssociation => fileAssociation.systemId === element.systemId)) {
+        if (!externalfileAssociations.some(fileAssociation => fileAssociation.pattern === element.pattern)) {
           externalfileAssociations.push(element);
         }
       });
@@ -54,7 +54,7 @@ export function getXmlExtensionApiImplementation(languageClient: LanguageClient,
     removeXMLFileAssociations: (fileAssociations: XMLFileAssociation[]) => {
       const externalfileAssociations = externalXmlSettings.xmlFileAssociations;
       fileAssociations.forEach(element => {
-        const itemIndex = externalfileAssociations.findIndex(fileAssociation => fileAssociation.systemId === element.systemId) //returns -1 if item not found
+        const itemIndex = externalfileAssociations.findIndex(fileAssociation => fileAssociation.pattern === element.pattern) //returns -1 if item not found
         if (itemIndex > -1) {
           externalfileAssociations.splice(itemIndex, 1);
         }

src/settings/settings.ts

@@ -243,7 +243,7 @@ export function getXMLSettings(javaHome: string | undefined, logfile: string, ex
     }
   })
   externalXmlSettings.xmlFileAssociations.forEach(element => {
-    if (!xml['xml']['fileAssociations'].some(fileAssociation => fileAssociation.systemId === element.systemId)) {
+    if (!xml['xml']['fileAssociations'].some(fileAssociation => fileAssociation.pattern === element.pattern)) {
       xml['xml']['fileAssociations'].push(element);
     }
   });