Skip to content

Commit 2ce720e

Browse files
committed
Update stuff
1 parent 3cc6a64 commit 2ce720e

File tree

5 files changed

+28
-25
lines changed

5 files changed

+28
-25
lines changed

crates/viewer/re_time_panel/src/data_density_graph.rs

+10-8
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
use std::sync::Arc;
77

88
use egui::emath::Rangef;
9-
use egui::{epaint::Vertex, lerp, pos2, remap, Color32, NumExt as _, Rect, Shape};
9+
use egui::{epaint::Vertex, lerp, pos2, remap, Color32, NumExt as _, Rect, Shape, Tooltip};
1010

1111
use re_chunk_store::Chunk;
1212
use re_chunk_store::RangeQuery;
@@ -421,14 +421,16 @@ pub fn data_density_graph_ui(
421421
if ui.ctx().dragged_id().is_none() {
422422
// TODO(jprochazk): check chunk.num_rows() and chunk.timeline.is_sorted()
423423
// if too many rows and unsorted, show some generic error tooltip (=too much data)
424-
egui::show_tooltip_at_pointer(
425-
ui.ctx(),
426-
ui.layer_id(),
424+
Tooltip::new(
427425
egui::Id::new("data_tooltip"),
428-
|ui| {
429-
show_row_ids_tooltip(ctx, ui, time_ctrl, db, item, hovered_time);
430-
},
431-
);
426+
ui.ctx().clone(),
427+
egui::PopupAnchor::Pointer,
428+
ui.layer_id(),
429+
)
430+
.gap(12.0)
431+
.show(|ui| {
432+
show_row_ids_tooltip(ctx, ui, time_ctrl, db, item, hovered_time);
433+
});
432434
}
433435
}
434436
}

crates/viewer/re_ui/examples/re_ui_example/main.rs

+2-1
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ mod drag_and_drop;
22
mod hierarchical_drag_and_drop;
33
mod right_panel;
44

5+
use egui::containers::menu;
56
use egui::Modifiers;
67
use re_ui::filter_widget::format_matching_text;
78
use re_ui::{
@@ -412,7 +413,7 @@ impl ExampleApp {
412413
}
413414
}
414415

415-
egui::menu::bar(ui, |ui| {
416+
menu::Bar::new().ui(ui, |ui| {
416417
ui.set_height(top_bar_style.height);
417418
ui.add_space(top_bar_style.indent);
418419

crates/viewer/re_ui/src/list_item/item_button.rs

+4-6
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
//! Abstraction for buttons to be used in list items.
22
33
use crate::{Icon, UiExt as _};
4+
use egui::containers::menu::SubMenuButton;
45

56
// -------------------------------------------------------------------------------------------------
67

@@ -51,12 +52,9 @@ impl super::ItemButton for ItemMenuButton<'_> {
5152
ui.add_enabled_ui(self.enabled, |ui| {
5253
ui.spacing_mut().item_spacing = egui::Vec2::ZERO;
5354

54-
let mut response = egui::menu::menu_custom_button(
55-
ui,
56-
ui.small_icon_button_widget(self.icon),
57-
self.add_contents,
58-
)
59-
.response;
55+
let (mut response, _) =
56+
SubMenuButton::from_button(ui.small_icon_button_widget(self.icon))
57+
.ui(ui, self.add_contents);
6058
if let Some(hover_text) = self.hover_text {
6159
response = response.on_hover_text(hover_text);
6260
}

crates/viewer/re_view_dataframe/src/view_query/ui.rs

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
use std::collections::{BTreeSet, HashSet};
2-
1+
use egui::containers::menu::SubMenuButton;
32
use re_chunk_store::{ColumnDescriptor, ColumnSelector};
43
use re_log_types::{
54
EntityPath, ResolvedTimeRange, TimeInt, TimeType, TimeZone, Timeline, TimelineName,
@@ -8,6 +7,7 @@ use re_types::blueprint::components;
87
use re_types_core::{ComponentName, ComponentNameSet};
98
use re_ui::{list_item, UiExt};
109
use re_viewer_context::{TimeDragValue, ViewId, ViewSystemExecutionError, ViewerContext};
10+
use std::collections::{BTreeSet, HashSet};
1111

1212
use crate::view_query::Query;
1313

@@ -434,7 +434,7 @@ impl Query {
434434

435435
ui.list_item_flat_noninteractive(list_item::PropertyContent::new("Columns").value_fn(
436436
|ui, _| {
437-
egui::menu::menu_button(ui, &visible_count_label, |ui| {
437+
SubMenuButton::new(&visible_count_label).ui(ui, |ui| {
438438
egui::ScrollArea::vertical()
439439
.auto_shrink([false, false])
440440
.show(ui, modal_ui)

crates/viewer/re_viewer/src/ui/rerun_menu.rs

+9-7
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
//! The main Rerun drop-down menu found in the top panel.
22
3-
use egui::containers::menu::MenuConfig;
4-
use egui::{NumExt as _, PopupCloseBehavior};
5-
3+
use crate::App;
4+
#[cfg(debug_assertions)]
5+
use egui::containers::menu;
6+
use egui::NumExt as _;
67
use re_ui::UICommand;
78
use re_viewer_context::StoreContext;
89

9-
use crate::App;
10-
1110
const SPACING: f32 = 12.0;
1211

1312
impl App {
@@ -99,8 +98,11 @@ impl App {
9998
backend_menu_ui(&self.command_sender, ui, render_state);
10099

101100
#[cfg(debug_assertions)]
102-
egui::containers::menu::SubMenuButton::new("Debug")
103-
.config(MenuConfig::new().close_behavior(PopupCloseBehavior::CloseOnClickOutside))
101+
menu::SubMenuButton::new("Debug")
102+
.config(
103+
menu::MenuConfig::new()
104+
.close_behavior(menu::PopupCloseBehavior::CloseOnClickOutside),
105+
)
104106
.ui(ui, |ui| {
105107
ui.style_mut().wrap_mode = Some(egui::TextWrapMode::Extend);
106108
debug_menu_options_ui(ui, &mut self.state.app_options, &self.command_sender);

0 commit comments

Comments
 (0)