Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expr: use ordered_float for all occurrences of f64 #670

Closed
skyzh opened this issue Jul 20, 2022 · 1 comment · Fixed by #699
Closed

expr: use ordered_float for all occurrences of f64 #670

skyzh opened this issue Jul 20, 2022 · 1 comment · Fixed by #699
Assignees
@Kikkon

Comments

@skyzh
Copy link
Member

skyzh commented Jul 20, 2022 •
edited
Loading

f64 is not Hash and Eq, which might cause issues for some implementations within the system.
@skyzh skyzh changed the title expr: use ordered_float for all occurrences of f64. expr: use ordered_float for all occurrences of f64 Jul 20, 2022
@Kikkon
Copy link
Contributor

Kikkon commented Aug 3, 2022

I'm learning type exercise 🤣 I want to try this

@skyzh skyzh mentioned this issue Sep 8, 2022
Merged
@wangrunji0408 wangrunji0408 mentioned this issue Oct 1, 2022
Merged
@Kikkon Kikkon mentioned this issue Oct 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kikkon Kikkon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce ordered float risinglightdb/risinglight
2 participants
@skyzh @Kikkon