Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wishlist/Enhancement - Add support for new option to only update existing file if etag has changed #300

Open
nutterthanos opened this issue Dec 9, 2023 · 4 comments

Comments

@nutterthanos
Copy link

This could help when an file's content has not changed but the timestamp has since changed and as such it downloads a existing file unnecessarily but how could this be implemented if such thing came to frutation?

What i thought was we would have to store the etags for each file if we have the option turned on in some form of database or something since if we don't store it if its supported by the server then again we are unnecessarily downloading a file thats its timestamp has somehow changed but not the actual files content

@nutterthanos nutterthanos changed the title Wishlist - Add support for new option to only update existing file if etag has changed Wishlist/Enhancement - Add support for new option to only update existing file if etag has changed Dec 10, 2023
@rockdaboot
Copy link
Owner

rockdaboot commented Dec 15, 2023

It's a good idea. Instead of maintaining a database, we could store the ETAG with the "--xattr" feature. These are extended attributes supported by the common Linux file systems. I know that we support FreeBSD extended attributes as well.

Currently we store user.xdg.origin.url, user.xdg.referrer.url, user.mime_type and user.charset.

Adding the ETAG here and making use of it is at least a start. WDYT?

@nutterthanos
Copy link
Author

It's a good idea. Instead of maintaining a database, we could store the ETAG with the "--xattr" feature. These are extended attributes supported by the common Linux file systems. I know that we support FreeBSD extended attributes as well.

Currently we store user.xdg.origin.url, user.xdg.referrer.url, user.mime_type and user.charset.

Adding the ETAG here and making use of it is at least a start. WDYT?

Yes I agree but what would be used on/with Windows and how does xattr store it?

@nutterthanos
Copy link
Author

Also some etag implementations are terrible as well

@nutterthanos
Copy link
Author

@rockdaboot has this been added or is somewhere in the pipeline and could you respond to above replies?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants