-
-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
warnWhenNotUsingParallelGC fails the build, warn is a confusing keyword here #152
Comments
I like the idea of the enum. I will play with this a bit. The thing is an enum can be tricky to use with the kotlin Gradle DSL since then you'll have to import the enum. A string might be better. |
overload a setter and have both :-)? |
I've been thinking about messages some more and I think an additional value would be useful. My scenario is that we've got a large team working on this but not everyone works on the build and as a result we're showing a lot of information to people who can't make good use of it. So something like Though I guess that leaves us without a good way to make use of the report |
Very good point. What does background do? Warn only? What about erroring the build? so maybe the tagging, warning, and error messages should all be configured independently? |
the way I see it: warnings should be shown but not fail the build, errors should always be shown and fail the build, anything silent should never fail the build. tag, background, or silent is just suggestions on name, neither should fail the build or be shown |
Currently
warnWhenNotUsingParallelGC
is a check that fails the buildNormally when I see the word
warn
I'd expect a warning to be printed but the build to succeed.Looking through at extension it seems like maybe these checks could benefit from being an enum like:
IGNORE, WARN, FAIL
The text was updated successfully, but these errors were encountered: