Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work in RTL #25

Open
EliezerB123 opened this issue Aug 25, 2021 · 0 comments
Open

Doesn't work in RTL #25

EliezerB123 opened this issue Aug 25, 2021 · 0 comments

Comments

@EliezerB123
Copy link

EliezerB123 commented Aug 25, 2021

Hi!

This plugin doesn't work in RTL, at ALL, not even a little.

We can't even use a workaround like direction:ltr;, like we can in most LTR-only plugins, because it appends items directly to the body.

Instead of appending text directly to the body for text measurement purposes, can we append it to a
<div style="direction:ltr;"> INSIDE the body?

This would be a simple workaround for RTL websites.

Edit:

As a workaround, I modified the library as follows:
I added
$('<div style="direction:ltr;text-align:left;"><div id="awesomecloud-text-marker"></div></div>').prependTo($('body'));

Then replaced all instances of $('body') with $('#awesomecloud-text-marker'); inside the library itself, and it works, now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant