Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crates.io version differs from GH version, breaking Miri #22

Closed
RalfJung opened this issue Jun 14, 2019 · 3 comments
Closed

crates.io version differs from GH version, breaking Miri #22

RalfJung opened this issue Jun 14, 2019 · 3 comments

Comments

@RalfJung
Copy link
Member

Miri is currently broken because it cannot build libstd with xargo, and fixing that does not work because the released version of this crate does not actually have the rustc-dep-of-std feature. In the tarball on crates.io, the Cargo.toml.orig looks like

[package]
name = "cfg-if"
version = "0.1.9"
authors = ["Alex Crichton <alex@alexcrichton.com>"]
license = "MIT/Apache-2.0"
readme = "README.md"
repository = "https://github.com/alexcrichton/cfg-if"
homepage = "https://github.com/alexcrichton/cfg-if"
documentation = "https://docs.rs/cfg-if"
description = """
A macro to ergonomically define an item depending on a large number of #[cfg]
parameters. Structured like an if-else chain, the first matching branch is the
item that gets emitted.
"""

[badges]
travis-ci = { repository = "alexcrichton/cfg-if" }

# [dependencies]
# core = { version = "1.0.0", optional = true, package = 'rustc-std-workspace-core' }
# compiler_builtins = { version = '0.1.2', optional = true }
#
# [features]
# rustc-dep-of-std = ['core', 'compiler_builtins']
@RalfJung
Copy link
Member Author

Ah turns out 0.1.8 has the feature, so this can be fixed in rustc without a new release here.

Still, something is odd here.

@alexcrichton
Copy link
Member

This is currently intentional and sounds like you found the issue elsewhere.

@RalfJung
Copy link
Member Author

I think it would still be better if the GH sources matched craters.io... this is extremely confusing when debugging what is going on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants