Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open VSX Registry: Awareness and Important Steps #7284

Closed
brianking opened this issue Jan 15, 2021 · 18 comments
Closed

Open VSX Registry: Awareness and Important Steps #7284

brianking opened this issue Jan 15, 2021 · 18 comments
Labels
S-actionable Someone could pick this issue up and work on it right now

Comments

@brianking
Copy link

@hybras has published this extension in the Open VSX Registry.

The service was recently transferred to the Eclipse Foundation and we want to ensure a seamless transition for our users. To ensure uninterrupted service and more exposure for your extension, I recommend the following.

To the maintainers: If you would like to take over publishing to open-vsx.org, here’s how: https://github.com/eclipse/openvsx/wiki/Publishing-Extensions

To the current publisher: Please sign the Eclipse Publisher Agreement. The signing process is explained in the Wiki (steps 1 and 2).

Claiming ownership of the namespace for your extension(s). To find out how to do this, see:
https://github.com/eclipse/openvsx/wiki/Namespace-Access
As owner you can add more namespace members (including service accounts) yourself in https://open-vsx.org/user-settings/namespaces. Note that publishing can be done by any contributor to the extension, namely those you add as namespace members once they have signed the Publisher Agreement as well.

Please also note that a license is now mandatory for publishing your extension to Open VSX. If your project doesn't have any license, please add one, preferably an open source license such as MIT. The publishing tool ovsx offers to automatically add the MIT license when you try to publish without a license.

Useful links:
Eclipse Publisher Agreement
Eclipse Foundation Open VSX Registry Frequently Asked Questions (FAQ)

More details are in these recent blog posts:
https://blogs.eclipse.org/post/brian-king/open-vsx-registry-under-new-management
https://blogs.eclipse.org/post/brian-king/new-era-open-vsx-registry

Today, there’s growing momentum around open source tools and technologies that support Visual Studio (VS) Code extensions. Leading global organizations are adopting these tools and technologies. This momentum has spurred demand for a marketplace without restrictions and limitations. We hope you join us on this journey as we continue to build the Open VSX community.
We look forward to continued innovation from you in 2021!

@hybras
Copy link

hybras commented Jan 15, 2021

Omg I completely forgot about this... Some more context:

I while ago I set up a GitHub action at this since deleted repo to publish the RA extension to Open VSX Registry, a store of extensions for open source VS Code forks (like vs codium). Since then, the registry came under new management and publishers needed to sign the linked agreement. I did not, having gone back to using vs code and forgetting about my action. Since then, it has been autopublished by open vsx's own bot, becoming abandonware. This all happened without the knowledge of anyone here (I think I asked around in the rust zulip before publishing if anyone wanted to do this, and decided to go ahead anyways)

I've since lost the source code (idk why I deleted the repo?). If anyone else wants to keep publishing the extension to open vsx, I can help in recreating the github action I made. My apologies for not keeping up with the publishing beforehand

@bjorn3
Copy link
Member

bjorn3 commented Jan 15, 2021

Depending on when you deleted the repo, it may still be restorable at https://github.com/settings/deleted_repositories. According to https://docs.github.com/en/free-pro-team@latest/github/administering-a-repository/restoring-a-deleted-repository you have 90 days the time after deletion.

@hybras
Copy link

hybras commented Jan 15, 2021

I've restored the repo, it says it may take up to an hour. I will disable my publishing action. The only benefit to keeping it running would be to claim ownership, since its now being autopublished by open vsx. I won't do that, seeing as I'm not matklad and Rust analyzer is not my property

Issue 4936 explains why you weren't already publishing yourselves (mainly the extra work associating with publishing and overhead of having more deps / secrets). FYI, I was using publish-vscode-extension. It takes the secret and path to the final vsix file as input. If you were to use it, it would replace the last step of the release workflow with the following

- name: Publish to Visual Studio Marketplace
  uses: HaaLeo/publish-vscode-extension@v0
  working-directory: ./editors/code
  with:
    pat: ${{ secrets.MARKETPLACE_TOKEN }}
    registryUrl: https://marketplace.visualstudio.com
    extensionFile: ../../dist/rust-analyzer.vsix
    packagePath: "" # note that this is being unset. See https://github.com/HaaLeo/publish-vscode-extension/issues/1
- name: Publish to Open VSX Registry
  uses: HaaLeo/publish-vscode-extension@v0
  working-directory: ./editors/code
  with:
    pat: ${{ secrets.OPEN_VSX_TOKEN }}
    extensionFile: ../../dist/rust-analyzer.vsix
    packagePath: "" # note that this is being unset. See https://github.com/HaaLeo/publish-vscode-extension/issues/1 

@lnicola lnicola added the S-actionable Someone could pick this issue up and work on it right now label Jan 18, 2021
@Progdrasil
Copy link

Would this change the stance from #4936? Since i'm using the VsCode build from my package manager i've stopped getting updates from Rust-Analyzer.

@nyanpasu64
Copy link

nyanpasu64 commented Jul 20, 2021

If there was supposed to be an auto-publishing system, I think it's broken; https://open-vsx.org/extension/matklad/rust-analyzer is now outdated (0.2.637) compared to https://marketplace.visualstudio.com/items?itemName=matklad.rust-analyzer (0.2.678), and Arch's vscode-oss has stopped getting updates to rust-analyzer.

@brianking
Copy link
Author

Related issue:
EclipseFdn/publish-extensions#342

I suggest filing a new issue there.

@lnicola
Copy link
Member

lnicola commented Jul 20, 2021

@matklad I think we should look into this. The Marketplace split is unfortunate, but VSCodium seems to be getting more and more popular and it seems unfair to exclude those users.

If we do this, we'll probably vendor publish-vscode-extension, like we did with gihub-release.

@matklad
Copy link
Member

matklad commented Jul 20, 2021

sgtm! Is the publish-vscode-extension github action required? Or can we add ovsx as a dev dependency and add an extra line here https://github.com/rust-analyzer/rust-analyzer/blob/3c5827cc18e0d1f0ec9fe32f731a362d27f2cfae/.github/workflows/release.yaml#L322 ?

@bjorn3
Copy link
Member

bjorn3 commented Jul 20, 2021

ovsx is used for the actual publishing it seems.

@cortopy
Copy link

cortopy commented Nov 15, 2021

The version in vsx registry is now well behind current: 0.2.784 vs 0.2.817

Would it be possible to update it?

@lnicola
Copy link
Member

lnicola commented Dec 21, 2021

@hybras (or anyone else), do you know if Open VSX supports the platform-specific extensions introduced in https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions?

CC #11080

EDIT:

Usage: ovsx publish [options] [extension.vsix]

Publish an extension, packaging it first if necessary.

Options:
  --packagePath <path>    Package and publish the extension at the specified path.
  --baseContentUrl <url>  Prepend all relative links in README.md with this URL.
  --baseImagesUrl <url>   Prepend all relative image links in README.md with this URL.
  --yarn                  Use yarn instead of npm while packing extension files.
  -h, --help              display help for command

Apparently not, vsce supports multiple --packagePath paths, for example, while ovsx doesn't. And there's no repository link on https://www.npmjs.com/package/ovsx.

@brianking
Copy link
Author

@hybras (or anyone else), do you know if Open VSX supports the platform-specific extensions introduced in https://code.visualstudio.com/api/working-with-extensions/publishing-extension#platformspecific-extensions?

Not yet (and no timeframe currently). It is being tracked at eclipse/openvsx#336

@hybras
Copy link

hybras commented Dec 21, 2021

I'm no longer interested in publishing RA to open vsx. please do not ping me

@lnicola
Copy link
Member

lnicola commented Dec 22, 2021

Sorry to bother you, then.

I still think this is something we should do, after the openvsx issues get sorted out.

@lnicola
Copy link
Member

lnicola commented Jan 12, 2022

@matklad would you be able to make an open-vsx.org account, get an access token, maybe claim the rust-analyzer namespace (I'm not sure how that works, though), and add it to the secrets on GitHub Actions? I'd do it myself, but I probably shouldn't own that account.

This isn't urgent, as I suspect eclipse/openvsx#336 will take more time to be implemented, but it would be nice to be prepared by then.

@lnicola
Copy link
Member

lnicola commented Jan 12, 2022

@matklad never mind, I've made an account for myself.

EDIT: hmm, it seems that the namespace needs to match the publisher field from package.json, which is you at the moment.

@jonas-schievink
Copy link
Contributor

Now that we'll publish under rust-lang.rust-analyzer instead of matklad.rust-analyzer on the VS Code marketplace, we should probably get the rust-lang namespace claimed on Open VSX too (not sure which account should own it though). I guess we'll see how well Open VSX handles the publisher move on monday.

@lnicola
Copy link
Member

lnicola commented Nov 4, 2022

rust-lang.rust-analyzer is now available on OpenVSX as a pre-release version. If nothing goes wrong, a stable release will be published as usual, next Monday.

Note that if you're still running matklad.rust-analyzer, it won't be automatically updated to the new version.

@lnicola lnicola closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-actionable Someone could pick this issue up and work on it right now
Projects
None yet
Development

No branches or pull requests

9 participants