Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generics/assoc_items: Confusing variable names #681

Closed
Seeker14491 opened this issue Dec 21, 2015 · 3 comments
Closed

generics/assoc_items: Confusing variable names #681

Seeker14491 opened this issue Dec 21, 2015 · 3 comments

Comments

@Seeker14491
Copy link
Contributor

To me, using the variable name number to refer to the first item, and the name digit to refer to the second item in the examples on 'The problem' and 'Associated types' pages is confusing. The names first_number and second_number would be better.
@mdinger
Copy link
Contributor

mdinger commented Dec 21, 2015

This would be good fix. Something like number1 and number2 might also be an option

@Seeker14491
Copy link
Contributor Author

@mdinger That's good too, though lets make it number_1 and number_2 to follow the naming conventions.

@mdinger
Copy link
Contributor

mdinger commented Dec 21, 2015

This is an easy fix so I won't implement it but anyone else is welcome to.

@Seeker14491 Seeker14491 mentioned this issue Dec 21, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mdinger @Seeker14491