Skip to content

Commit 4353b1e

Browse files
committed
Auto merge of #113450 - Nilstrieb:src/bootstrap/test.rs, r=flip1995
Fail the build if clippy tests don't pass This was removed in de69d55#diff-8479eab02701e686aedb15b567dc8fc31220c6e4efb9565ccc9d662b7fee2214 which caused CI to ignore clippy failures. This adds back the exit, which should cause CI to fail again if a test is broken (like right now, as clippy tests are broken on master). Also see https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/CI.20doesn't.20care.20about.20clippy.20test.20failures.20but.20only.20sometime r? flip1995
2 parents 9bb6fbe + d8c29b8 commit 4353b1e

File tree

3 files changed

+4
-19
lines changed

3 files changed

+4
-19
lines changed

src/bootstrap/test.rs

+4
Original file line numberDiff line numberDiff line change
@@ -799,6 +799,10 @@ impl Step for Clippy {
799799
// The tests succeeded; nothing to do.
800800
return;
801801
}
802+
803+
if !builder.config.cmd.bless() {
804+
crate::detail_exit_macro!(1);
805+
}
802806
}
803807
}
804808

src/tools/clippy/tests/ui/to_string_in_format_args_incremental.rs

-9
This file was deleted.

src/tools/clippy/tests/ui/to_string_in_format_args_incremental.stderr

-10
This file was deleted.

0 commit comments

Comments
 (0)