Skip to content

Commit 5e7e8cd

Browse files
authored
Update attributes.rs
Some comment refinements inspired by review feedback.
1 parent e7e6dec commit 5e7e8cd

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/librustc_codegen_llvm/attributes.rs

+5-4
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ pub fn from_fn_attrs(
281281
//
282282
// However, in the long term we should either:
283283
// - fold this into final else (i.e. stop inspecting `id`)
284-
// - adopt Rust PR #63909.
284+
// - or, adopt Rust PR #63909.
285285
//
286286
// see also Rust RFC 2753.
287287

@@ -302,9 +302,10 @@ pub fn from_fn_attrs(
302302
// UB otherwise. (At least for now; see also
303303
// rust-lang/rust#63909 and Rust RFC 2753.)
304304
//
305-
// Items defined in Rust with non-Rust ABIs (case 2) are
306-
// defined to not unwind. We insert shims to abort if an
307-
// unwind happens to enforce this.
305+
// Items defined in Rust with non-Rust ABIs (case 2) are also
306+
// not supposed to unwind. Whether this should be enforced
307+
// (versus stating it is UB) and *how* it would be enforced
308+
// is currently under discussion; see rust-lang/rust#58794.
308309
//
309310
// In either case, we mark item as explicitly nounwind.
310311
false

0 commit comments

Comments
 (0)