Skip to content

Commit 7334552

Browse files
committed
Fix compilation issues on other unixes
Signed-off-by: Alex Saveau <saveau.alexandre@gmail.com>
1 parent e0a1549 commit 7334552

File tree

2 files changed

+51
-44
lines changed

2 files changed

+51
-44
lines changed

library/std/src/sys/pal/unix/fs.rs

+48-2
Original file line numberDiff line numberDiff line change
@@ -1980,14 +1980,60 @@ fn open_to_and_set_permissions(
19801980
Ok((writer, writer_metadata))
19811981
}
19821982

1983+
mod cfm {
1984+
use crate::fs::{File, Metadata};
1985+
use crate::io::{BorrowedCursor, IoSlice, IoSliceMut, Read, Result, Write};
1986+
1987+
pub struct CachedFileMetadata(pub File, pub Metadata);
1988+
1989+
impl Read for CachedFileMetadata {
1990+
fn read(&mut self, buf: &mut [u8]) -> Result<usize> {
1991+
self.0.read(buf)
1992+
}
1993+
fn read_vectored(&mut self, bufs: &mut [IoSliceMut<'_>]) -> Result<usize> {
1994+
self.0.read_vectored(bufs)
1995+
}
1996+
fn read_buf(&mut self, cursor: BorrowedCursor<'_>) -> Result<()> {
1997+
self.0.read_buf(cursor)
1998+
}
1999+
#[inline]
2000+
fn is_read_vectored(&self) -> bool {
2001+
self.0.is_read_vectored()
2002+
}
2003+
fn read_to_end(&mut self, buf: &mut Vec<u8>) -> Result<usize> {
2004+
self.0.read_to_end(buf)
2005+
}
2006+
fn read_to_string(&mut self, buf: &mut String) -> Result<usize> {
2007+
self.0.read_to_string(buf)
2008+
}
2009+
}
2010+
impl Write for CachedFileMetadata {
2011+
fn write(&mut self, buf: &[u8]) -> Result<usize> {
2012+
self.0.write(buf)
2013+
}
2014+
fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> Result<usize> {
2015+
self.0.write_vectored(bufs)
2016+
}
2017+
#[inline]
2018+
fn is_write_vectored(&self) -> bool {
2019+
self.0.is_write_vectored()
2020+
}
2021+
#[inline]
2022+
fn flush(&mut self) -> Result<()> {
2023+
self.0.flush()
2024+
}
2025+
}
2026+
}
2027+
pub(crate) use cfm::CachedFileMetadata;
2028+
19832029
#[cfg(not(target_vendor = "apple"))]
19842030
pub fn copy(from: &Path, to: &Path) -> io::Result<u64> {
19852031
let (reader, reader_metadata) = open_from(from)?;
19862032
let (writer, writer_metadata) = open_to_and_set_permissions(to, &reader_metadata)?;
19872033

19882034
io::copy(
1989-
&mut crate::sys::kernel_copy::CachedFileMetadata(reader, reader_metadata),
1990-
&mut crate::sys::kernel_copy::CachedFileMetadata(writer, writer_metadata),
2035+
&mut CachedFileMetadata(reader, reader_metadata),
2036+
&mut CachedFileMetadata(writer, writer_metadata),
19912037
)
19922038
}
19932039

library/std/src/sys/pal/unix/kernel_copy.rs

+3-42
Original file line numberDiff line numberDiff line change
@@ -52,8 +52,8 @@ use crate::cmp::min;
5252
use crate::fs::{File, Metadata};
5353
use crate::io::copy::generic_copy;
5454
use crate::io::{
55-
BorrowedCursor, BufRead, BufReader, BufWriter, Error, IoSlice, IoSliceMut, Read, Result,
56-
StderrLock, StdinLock, StdoutLock, Take, Write,
55+
BufRead, BufReader, BufWriter, Error, Read, Result, StderrLock, StdinLock, StdoutLock, Take,
56+
Write,
5757
};
5858
use crate::mem::ManuallyDrop;
5959
use crate::net::TcpStream;
@@ -65,6 +65,7 @@ use crate::process::{ChildStderr, ChildStdin, ChildStdout};
6565
use crate::ptr;
6666
use crate::sync::atomic::{AtomicBool, AtomicU8, Ordering};
6767
use crate::sys::cvt;
68+
use crate::sys::fs::CachedFileMetadata;
6869
use crate::sys::weak::syscall;
6970

7071
#[cfg(test)]
@@ -537,46 +538,6 @@ impl<T: ?Sized + CopyWrite> CopyWrite for BufWriter<T> {
537538
}
538539
}
539540

540-
pub(crate) struct CachedFileMetadata(pub File, pub Metadata);
541-
542-
impl Read for CachedFileMetadata {
543-
fn read(&mut self, buf: &mut [u8]) -> Result<usize> {
544-
self.0.read(buf)
545-
}
546-
fn read_vectored(&mut self, bufs: &mut [IoSliceMut<'_>]) -> Result<usize> {
547-
self.0.read_vectored(bufs)
548-
}
549-
fn read_buf(&mut self, cursor: BorrowedCursor<'_>) -> Result<()> {
550-
self.0.read_buf(cursor)
551-
}
552-
#[inline]
553-
fn is_read_vectored(&self) -> bool {
554-
self.0.is_read_vectored()
555-
}
556-
fn read_to_end(&mut self, buf: &mut Vec<u8>) -> Result<usize> {
557-
self.0.read_to_end(buf)
558-
}
559-
fn read_to_string(&mut self, buf: &mut String) -> Result<usize> {
560-
self.0.read_to_string(buf)
561-
}
562-
}
563-
impl Write for CachedFileMetadata {
564-
fn write(&mut self, buf: &[u8]) -> Result<usize> {
565-
self.0.write(buf)
566-
}
567-
fn write_vectored(&mut self, bufs: &[IoSlice<'_>]) -> Result<usize> {
568-
self.0.write_vectored(bufs)
569-
}
570-
#[inline]
571-
fn is_write_vectored(&self) -> bool {
572-
self.0.is_write_vectored()
573-
}
574-
#[inline]
575-
fn flush(&mut self) -> Result<()> {
576-
self.0.flush()
577-
}
578-
}
579-
580541
impl CopyRead for CachedFileMetadata {
581542
fn properties(&self) -> CopyParams {
582543
CopyParams(FdMeta::Metadata(self.1.clone()), Some(self.0.as_raw_fd()))

0 commit comments

Comments
 (0)