Skip to content

Commit 8343806

Browse files
committed
add fixme about the type_op_normalize query in NLL HRTB diagnostics
1 parent 311578d commit 8343806

File tree

1 file changed

+7
-1
lines changed

1 file changed

+7
-1
lines changed

compiler/rustc_mir/src/borrow_check/diagnostics/bound_region_errors.rs

+7-1
Original file line numberDiff line numberDiff line change
@@ -246,8 +246,14 @@ where
246246
let mut fulfill_cx = <dyn TraitEngine<'_>>::new(tcx);
247247

248248
let mut selcx = SelectionContext::new(infcx);
249-
let (param_env, value) = key.into_parts();
250249

250+
// FIXME(lqd): Unify and de-duplicate the following with the actual
251+
// `rustc_traits::type_op::type_op_normalize` query to allow the span we need in the
252+
// `ObligationCause`. The normalization results are currently different between
253+
// `AtExt::normalize` used in the query and `normalize` called below: the former fails
254+
// to normalize the `nll/relate_tys/impl-fn-ignore-binder-via-bottom.rs` test. Check
255+
// after #85499 lands to see if its fixes have erased this difference.
256+
let (param_env, value) = key.into_parts();
251257
let Normalized { value: _, obligations } = rustc_trait_selection::traits::normalize(
252258
&mut selcx,
253259
param_env,

0 commit comments

Comments
 (0)