Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mark C ABI functions as nounwind #18512

Closed
thestinger opened this issue Nov 1, 2014 · 2 comments
Closed

mark C ABI functions as nounwind #18512

thestinger opened this issue Nov 1, 2014 · 2 comments
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.

Comments

@thestinger
Copy link
Contributor

It's explicitly undefined to unwind past an FFI boundary, so these functions can be considered nounwind. The soundness hole allowing safe Rust code to unwind past FFI boundaries should be fixed first (#18510).
@thestinger thestinger added I-slow Issue: Problems and improvements with respect to performance of generated code. A-codegen Area: Code generation labels Nov 1, 2014
@Aatch Aatch mentioned this issue Jan 15, 2015
Closed
@emberian emberian self-assigned this Mar 25, 2015
@emberian emberian removed their assignment Jan 5, 2016
@bstrie
Copy link
Contributor

bstrie commented Jul 14, 2016 •
edited
Loading

As far as I can tell, the resolution to this bug was originally implemented in #21186 , which was postponed while waiting for the decision on the RFC at rust-lang/rfcs#638 , which was eventually rejected in favor of rust-lang/rfcs#1236 , which is now implemented and stabilized. @Aatch, do you think we can make progress here now?

@Aatch
Copy link
Contributor

Aatch commented Jul 19, 2016

Looks like C functions are marked nounwind now.

@Aatch Aatch closed this as completed Jul 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-codegen Area: Code generation I-slow Issue: Problems and improvements with respect to performance of generated code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark extern functions as nounwind + other unwinding-based improvements Aatch/rust
4 participants
@Aatch @emberian @bstrie @thestinger