1.52 run-make-fulldeps tests relies on rust-llvm-dwp in PATH before it is installed there

[infinity0]

See e.g. https://buildd.debian.org/status/fetch.php?pkg=rustc&arch=armhf&ver=1.52.0%7Ebeta.3%2Bdfsg1-1%7Eexp1&stamp=1620148050&raw=0 (warning very large page)

$ grep rust-llvm-dwp ../fetch.php\?pkg\=rustc\&arch\=armhf\&ver\=1.52.0~beta.3+dfsg1-1~exp1\&stamp\=1620148050\&raw\=1 
Copy "/usr/lib/llvm-11/bin/llvm-dwp" to "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/stage1/lib/rustlib/armv7-unknown-linux-gnueabihf/bin/rust-llvm-dwp"
Copy "/usr/lib/llvm-11/bin/llvm-dwp" to "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/stage2/lib/rustlib/armv7-unknown-linux-gnueabihf/bin/rust-llvm-dwp"
Copy "/usr/lib/llvm-11/bin/llvm-dwp" to "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/stage1/lib/rustlib/armv7-unknown-linux-gnueabihf/bin/rust-llvm-dwp"
Copy "/usr/lib/llvm-11/bin/llvm-dwp" to "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/stage2/lib/rustlib/armv7-unknown-linux-gnueabihf/bin/rust-llvm-dwp"
error: linking dwarf objects with `rust-llvm-dwp` failed: exit code: 1
  = note: "rust-llvm-dwp" "-e" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-dwarf/split-dwarf/foo" "-o" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-dwarf/split-dwarf/foo.dwp"
error: linking dwarf objects with `rust-llvm-dwp` failed: exit code: 1
  = note: "rust-llvm-dwp" "-e" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-debuginfo/split-debuginfo/foo" "-o" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-debuginfo/split-debuginfo/foo.dwp"

context:

error: linking dwarf objects with `rust-llvm-dwp` failed: exit code: 1
  |
  = note: "rust-llvm-dwp" "-e" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-debuginfo/split-debuginfo/foo" "-o" "/<<PKGBUILDDIR>>/build/armv7-unknown-linux-gnueabihf/test/run-make-fulldeps/split-debuginfo/split-debuginfo/foo.dwp"
  = note: 
  = note: error: No such file or directory

We can see that llvm-dwp is copied to the output bin directory [1], however the tests do not set this path correctly and instead try to use plain rust-llvm-dwp from PATH which doesn't exist yet.

[1] actually this is not necessary if using an external llvm, as you can see the process in Debian is copying /usr/lib/llvm-11/bin/llvm-dwp, but no big deal I can just ignore the copy in the output bin directory.

[infinity0]

Oh never mind, it seems rust-llvm-dwp was added to the 1.51 release so it is expected to be in PATH. I failed to notice this for the 1.51 release for the Debian package and didn't put it in there.

[infinity0]

There is actually an issue, reported in #85471