Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Can't click any links in methods that use details #91184

Closed
camelid opened this issue Nov 24, 2021 · 5 comments · Fixed by #91188
Closed

rustdoc: Can't click any links in methods that use details #91184

camelid opened this issue Nov 24, 2021 · 5 comments · Fixed by #91188
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Milestone
1.58.0

Comments

@camelid
Copy link
Member

camelid commented Nov 24, 2021

For example, I can't click any links (i.e., when I click them, nothing happens) in this method's header. Likewise, I can't click any links for make_async_expr, but I can click links in wrap_in_try_constructor, which has no details tag.

This same behavior occurs in the std docs, though every std method is documented and thus has a details tag, so there's no comparison to non-details methods.

This is a regression in nightly 1.58.0. I'm using Safari on macOS; I don't know if this reproduces on other browsers.
@camelid camelid added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. C-bug Category: This is a bug. A-rustdoc-ui Area: Rustdoc UI (generated HTML) labels Nov 24, 2021
@camelid camelid added this to the 1.58.0 milestone Nov 24, 2021
@rustbot rustbot added the I-prioritize Issue: Indicates that prioritization has been requested for this issue. label Nov 24, 2021
@jyn514
Copy link
Member

jyn514 commented Nov 24, 2021

This is probably #91103; I don't know why that change was made or if this is intentional.

cc @Manishearth @jsha

@camelid
Copy link
Member Author

camelid commented Nov 24, 2021

I can't imagine this part of the behavior is intentional, since it breaks a lot of rustdoc's UI.

@camelid camelid added the E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc label Nov 24, 2021
@camelid
Copy link
Member Author

camelid commented Nov 24, 2021

We really need more GUI tests so this can't happen again...

@jsha
Copy link
Contributor

jsha commented Nov 24, 2021

Can confirm, that wasn't intentional. I manually checked during development to make sure that wouldn't happen, but it must have broken. Sorry for that, and sorry for not adding a GUI test for it. I'll post a fix in a moment.

@jsha jsha mentioned this issue Nov 24, 2021
Merged
@camelid camelid added P-critical Critical priority and removed E-needs-bisection Call for participation: This issue needs bisection: https://github.com/rust-lang/cargo-bisect-rustc I-prioritize Issue: Indicates that prioritization has been requested for this issue. labels Nov 24, 2021
@camelid
Copy link
Member Author

camelid commented Nov 24, 2021

Assigning priority as discussed in the prioritization working group.

@bors bors closed this as completed in b426445 Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-rustdoc-ui Area: Rustdoc UI (generated HTML) C-bug Category: This is a bug. P-critical Critical priority regression-from-stable-to-nightly Performance or correctness regression from stable to nightly. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.58.0
Development

Successfully merging a pull request may close this issue.

Fix clicking on anchors inside summary tags jsha/rust
4 participants
@jsha @jyn514 @camelid @rustbot