refactor(dev): improve Ansible ComfyUI password behavior (yondonfu#127)

This commit ensures that a unique password is generated on each run unless
the user specifies a password themselves, making the deployment more secure.
It allows users to provide their own password via extra-vars or environment
variables while automatically generating a random password if none is provided.
It also improves the ComfyUI caddy file template name.

Author: rickstaa

.gitignore

@@ -2,8 +2,9 @@ __pycache__
 *.egg-info
 build
 .DS_STORE
-comfyui*
-ComfyUI*
+comfyui/
+ComfyUI/
+cuda_temp
 
 # VS Code settings
 .vscode/
@@ -18,4 +19,4 @@ launch.json
 .env.test
 .env.production
 
-nodes/web/static/*
+nodes/web/static/*

scripts/README.md

@@ -45,8 +45,12 @@ This repository includes an [Ansible playbook](https://docs.ansible.com/ansible/
    > [!IMPORTANT]  
    > When using a non-sudo user, add `--ask-become-pass` to provide the sudo password or use an Ansible vault for secure storage.
 
-7. Access the Server:
-   Once the **Ansible playbook** completes successfully, the **ComfyStream** container will start, downloading models and building TensorRT engines. When ready, access **ComfyUI** at `https://<VM_IP>:<PORT_THAT_FORWARDS_TO_8189>`.
+7. **Access the Server**:  
+   After the playbook completes, **ComfyStream** will start, and you can access **ComfyUI** at `https://<VM_IP>:<PORT_FOR_8189>`. Credentials are shown in the output and regenerated each time. To persist the password, set the `comfyui_password` variable when running the playbook:
+
+   ```bash
+   ansible-playbook -i ansible/inventory.yaml ansible/plays/setup_comfystream.yaml -e "comfyui_password=YourSecurePasswordHere"
+   ```
 
 > [!IMPORTANT]
 > If you encounter a `toomanyrequests` error while pulling the Docker image, either wait a few minutes or provide your Docker credentials when running the playbook:  

scripts/ansible/plays/setup_comfystream.yaml

@@ -5,9 +5,12 @@
   vars:
     docker_image: "livepeer/comfystream:0.0.3"
     comfyui_username: "comfyadmin"
-    comfyui_password: "Ge}_^jn?*?5#/|FWx9I&K|S0$/)#au8" # Set your own secure password!
 
   tasks:
+    # Retrieve ComfyUI server password
+    - name: Set ComfyUI password (static if provided, random if empty)
+      set_fact:
+        comfyui_password: "{{ comfyui_password | default(lookup('password', '/dev/null length=32 chars=ascii_letters,digits')) }}"
     # Wait till VM is ready
     - name: Check if we can connect to the VM
       wait_for_connection:
@@ -126,18 +129,18 @@
         - /etc/caddy/certificates/selfsigned.key
         - /etc/caddy/certificates/selfsigned.crt
       notify: restart caddy
-    - name: Create Caddy configuration for Comfystream
+    - name: Create Caddy configuration for ComfyUI server
       template:
-        src: ../../templates/comfystream.caddy.j2
-        dest: /etc/caddy/comfystream.caddy
+        src: ../../templates/comfyui.caddy.j2
+        dest: /etc/caddy/comfyui.caddy
         owner: caddy
         group: caddy
         mode: "0644"
       notify: restart caddy
-    - name: Ensure Caddyfile includes Comfystream configuration
+    - name: Ensure Caddyfile includes ComfyUI server configuration
       lineinfile:
         path: /etc/caddy/Caddyfile
-        line: "import /etc/caddy/comfystream.caddy"
+        line: "import /etc/caddy/comfyui.caddy"
         create: yes
       notify: restart caddy
     # Ensure NVIDIA Container Toolkit is installed and configured
@@ -246,7 +249,7 @@
         command: "--download-models --build-engines --server"
     - name: Display Ansible completion message
       debug:
-        msg: ComfyStream is starting up, downloading models, and building TensorRT engines—this may take a while. Access ComfyUI when ready at https://<hosturl>:<COMFYUIPort>.
+        msg: "ComfyStream is starting up, downloading models, and building TensorRT engines—this may take a while. Access ComfyUI when ready at https://{{ ansible_default_ipv4.address }}:<COMFYUIPort>."
 
   handlers:
     - name: restart caddy

scripts/spinup_comfystream_tensordock.py

@@ -52,7 +52,7 @@
     "operating_system": "Ubuntu 22.04 LTS",
 }
 CADDY_TEMPLATE_PATH = os.path.join(
-    os.path.dirname(__file__), "templates", "comfystream.caddy.j2"
+    os.path.dirname(__file__), "templates", "comfyui.caddy.j2"
 )
 CLOUD_INIT_TEMPLATE_PATH = os.path.join(
     os.path.dirname(__file__), "templates", "cloud_init_comfystream.yaml.j2"