Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove start_version and end_version #1223

Closed
nex3 opened this issue Mar 11, 2018 · 0 comments · Fixed by #1375
Closed

Remove start_version and end_version #1223

nex3 opened this issue Mar 11, 2018 · 0 comments · Fixed by #1375

Comments

@nex3
Copy link
Contributor

nex3 commented Mar 11, 2018

Once #1222 is done, I don't think it'll make much sense at all to talk about version numbers for Sass as a language, or to track them as part of our specs. Instead, I think we should focus on which features are supported by which implementations.

Dart Sass may eventually want to switch to multi-tier development, like Ruby Sass's stable/next/master distinction, but I still don't think tracking language versions is the right way to do that. Instead, I think we should extend todo and ignore_for to support implementation-level version numbers. For example:

---
:ignore_for:
- dart-sass < 1.1

would only run the test on Dart Sass 1.0.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant