Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not install correctly using yarn #45

Closed
area opened this issue Jun 26, 2017 · 3 comments
Closed

Does not install correctly using yarn #45

area opened this issue Jun 26, 2017 · 3 comments
Assignees

Comments

@area
Copy link
Contributor

area commented Jun 26, 2017

Unlike npm, yarn does not install binaries of dependencies to ./node_modules/.bin (see here). As a result when we try and run testrpc-sc, it fails. This could be fixed by executing ./node_modules/ethereumjs-testrpc-sc/bin/testrpc rather than ./node_modules/.bin/testrpc-sc. Alternatively, the onus could be on the use a tool like yarn-bin-fix.

@cgewecke
Copy link
Member

Yes, changing the path here seems reasonable. As long as we're confident that ethereumjs-testrpc-sc will always get installed at that location in node_modules and not be nested somewhere weird. But it should be right?

@cgewecke
Copy link
Member

Published with 0.1.4.

@cgewecke
Copy link
Member

An additional note here: Have removed the post-install hook from our solidity-parser fork following Elena's observation that yarn dgafs that. So changes there are now slightly more complicated - when we pull the upstream master we have to npm run build and push the build too. And I believe anyone using yarn has to run yarn update solidity-coverage to see it.

If this new approach is mistaken please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants