Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pip check to CI workflows #39

Closed
pvk-developer opened this issue Nov 2, 2021 · 0 comments · Fixed by #40
Closed

Add pip check to CI workflows #39

pvk-developer opened this issue Nov 2, 2021 · 0 comments · Fixed by #40
Assignees
@pvk-developer
Labels
internal The issue doesn't change the API or functionality

Comments

@pvk-developer
Copy link
Member

The current CI workflows and local test and lint commands do not catch dependency incompatibilities.

For example, installing the repository for development on the master branch results in these errors:

ERROR: autopep8 1.6.0 has requirement pycodestyle>=2.8.0, but you'll have pycodestyle 2.7.0 which is incompatible.

A pip check command should be made part of the local and CI tests to make sure that our dependency tree is always clean.
@pvk-developer pvk-developer added the internal The issue doesn't change the API or functionality label Nov 2, 2021
@pvk-developer pvk-developer self-assigned this Nov 2, 2021
@pvk-developer pvk-developer mentioned this issue Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pvk-developer pvk-developer

Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pip check to workflows sdv-dev/DeepEcho
1 participant
@pvk-developer