Skip to content

Commit 5a10385

Browse files
Remove timestamping authority (sigstore#813)
See sigstore#812 for more discussion. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
1 parent b181b0b commit 5a10385

38 files changed

+33
-3263
lines changed

CODEOWNERS

-3
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,6 @@
55

66
/pkg/types/ @bobcallaway
77

8-
/pkg/api/timestamp.go @asraa @loosebazooka
9-
/pkg/types/rfc3161/ @asraa @loosebazooka
10-
118
# The CODEOWNERS are managed via a GitHub team, but the current list is (in alphabetical order):
129

1310
# asraa

FEATURES.md

-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@ This doc covers feature stability in `rekor` as described in the [API Stability
77

88
## Beta
99
* Rekor API, defined [here](https://github.com/sigstore/rekor/blob/main/openapi.yaml)
10-
* The Rekor RFC 3161 timestamping service
1110
* `rekor-cli` CLI tool
1211
* The `rekor/pkg/client` client library
1312

Makefile

+5-3
Original file line numberDiff line numberDiff line change
@@ -90,9 +90,11 @@ rekor-server: $(SRCS)
9090
test:
9191
go test ./...
9292

93-
fuzz: $(GO-FUZZ-BUILD)
94-
# This is a hack because of this bug https://github.com/golang/go/issues/44129
95-
cd tests/fuzz;GOFLAGS=-mod=mod $(GO-FUZZ-BUILD);cd ../../;go mod tidy
93+
# there is no fuzzing currently
94+
fuzz: ;
95+
# Once fuzzing is added, uncomment below
96+
# This is a hack because of this bug https://github.com/golang/go/issues/44129
97+
# cd tests/fuzz;GOFLAGS=-mod=mod $(GO-FUZZ-BUILD);cd ../../;go mod tidy
9698

9799
clean:
98100
rm -rf dist

cmd/rekor-cli/app/timestamp.go

-200
This file was deleted.

cmd/rekor-cli/app/timestamp_test.go

-130
This file was deleted.

cmd/rekor-server/app/root.go

-1
Original file line numberDiff line numberDiff line change
@@ -69,7 +69,6 @@ func init() {
6969
rootCmd.PersistentFlags().String("rekor_server.hostname", "rekor.sigstore.dev", "public hostname of instance")
7070
rootCmd.PersistentFlags().String("rekor_server.address", "127.0.0.1", "Address to bind to")
7171
rootCmd.PersistentFlags().String("rekor_server.signer", "memory", "Rekor signer to use. Current valid options include: [gcpkms, memory]")
72-
rootCmd.PersistentFlags().String("rekor_server.timestamp_chain", "", "PEM encoded cert chain signing authorizing the signer to be a CA to sign a timestamping cert")
7372

7473
rootCmd.PersistentFlags().Uint16("port", 3000, "Port to bind to")
7574

config/rekor.yaml

+1-7
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ spec:
5959
"--rekor_server.signer=$(KMS)",
6060
"--trillian_log_server.sharding_config=/sharding/sharding-config.yaml",
6161
"--enable_attestation_storage=$(ENABLE_ATTESTATION_STORAGE)",
62-
"--attestation_storage_bucket=$(ATTESTATION_BUCKET)",
63-
"--rekor_server.timestamp_chain=$(TIMESTAMP_CHAIN)"
62+
"--attestation_storage_bucket=$(ATTESTATION_BUCKET)"
6463
]
6564
volumeMounts:
6665
- name: sharding-config
@@ -81,11 +80,6 @@ spec:
8180
configMapKeyRef:
8281
name: rekor-config
8382
key: attestation_bucket
84-
- name: TIMESTAMP_CHAIN
85-
valueFrom:
86-
configMapKeyRef:
87-
name: rekor-config
88-
key: timestamp_chain
8983
resources:
9084
requests:
9185
memory: "1G"

0 commit comments

Comments
 (0)